linux-kernel - Re: [PATCH 1/2] brcmfmac: remove unreachable poll mode for sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8862907338725d48e4966993e639f680d59156ad.camel@czerwinskis.de>
Date: Tue, 15 Jul 2025 10:30:36 +0200
From: Rouven Czerwinski <rouven@...rwinskis.de>
To: Arend Van Spriel <arend.vanspriel@...adcom.com>
Cc: kernel@...gutronix.de, linux-wireless@...r.kernel.org, 
	brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] brcmfmac: remove unreachable poll mode for sdio

Hi Arend,

On Tue, 2025-07-08 at 18:32 +0200, Arend Van Spriel wrote:
> On June 21, 2025 1:29:17 PM Rouven Czerwinski <rouven@...rwinskis.de>
> wrote:
> 
> > The sdio interface implements an unreachable poll mode. Remove it
> > since
> > the code can't be reached, if the poll mode needs to be implemented
> > it
> > can simply be resurrected using the usual git means.
> 
> Thanks, Rouven
> 
> This functionality has been/can be useful so instead of ripping it
> out I 
> would prefer to have a proper knob for it in debugfs.

It's probably easier to make this a module parameter instead, I think
that live switching may be harder to implement.

That said, I no longer have access to the hardware where this can be
tested, so I can't continue with this suggestion.

Thanks for the input and Regards,
Rouven

> 
> Regards,
> Arend
> 
> > Signed-off-by: Rouven Czerwinski <rouven@...rwinskis.de>
> > ---
> > .../broadcom/brcm80211/brcmfmac/sdio.c        | 48 +---------------
> > ---
> > 1 file changed, 2 insertions(+), 46 deletions(-)
>