| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<FR2PPF4571F02BC266F9F1668F1BB0CF4868C57A@FR2PPF4571F02BC.DEUP281.PROD.OUTLOOK.COM>
Date: Tue, 15 Jul 2025 09:17:12 +0000
From: Remi Buisson <Remi.Buisson@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
"oe-kbuild@...ts.linux.dev"
<oe-kbuild@...ts.linux.dev>,
Remi Buisson via B4 Relay
<devnull+remi.buisson.tdk.com@...nel.org>,
Jonathan Cameron
<jic23@...nel.org>,
David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko
<andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski
<krzk@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
CC: "lkp@...el.com" <lkp@...el.com>,
"oe-kbuild-all@...ts.linux.dev"
<oe-kbuild-all@...ts.linux.dev>,
"linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>,
"linux-iio@...r.kernel.org"
<linux-iio@...r.kernel.org>,
"devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>
Subject: RE: [PATCH v2 5/8] iio: imu: inv_icm45600: add I2C driver for
inv_icm45600 driver
>
>
>From: Dan Carpenter <dan.carpenter@...aro.org>
>Sent: Monday, July 14, 2025 10:21 PM
>To: oe-kbuild@...ts.linux.dev; Remi Buisson via B4 Relay <devnull+remi.buisson.tdk.com@...nel.org>; Jonathan Cameron <jic23@...nel.org>; David Lechner <dlechner@...libre.com>; Nuno Sá <nuno.sa@...log.com>; Andy Shevchenko <andy@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk@...nel.org>; Conor Dooley <conor+dt@...nel.org>
>Cc: lkp@...el.com; oe-kbuild-all@...ts.linux.dev; linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org; devicetree@...r.kernel.org; Remi Buisson <Remi.Buisson@....com>
>Subject: Re: [PATCH v2 5/8] iio: imu: inv_icm45600: add I2C driver for inv_icm45600 driver
>
>Hi Remi,
>
>kernel test robot noticed the following build warnings:
>
>url: https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commits/Remi-Buisson-via-B4-Relay/dt-bindings-iio-imu-Add-inv_icm45600/20250710-170143__;!!FtrhtPsWDhZ6tw!GO8R3ZuhZ1VFpLzHNMxNgLQh_MnTqOf0QfhvgAVIMg15J6EFXJwPIClI9Xn3AWrYrSg0AGwenDxAngczRVPS8ZEa$[github[.]com]
>base: f8f559752d573a051a984adda8d2d1464f92f954
>patch link: https://urldefense.com/v3/__https://lore.kernel.org/r/20250710-add_newport_driver-v2-5-bf76d8142ef2*40tdk.com__;JQ!!FtrhtPsWDhZ6tw!GO8R3ZuhZ1VFpLzHNMxNgLQh_MnTqOf0QfhvgAVIMg15J6EFXJwPIClI9Xn3AWrYrSg0AGwenDxAngczRXeV1o-2$[lore[.]kernel[.]org]
>patch subject: [PATCH v2 5/8] iio: imu: inv_icm45600: add I2C driver for inv_icm45600 driver
>config: s390-randconfig-r073-20250712 (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/20250713/202507130115.7g0XWB2E-lkp@intel.com/config__;!!FtrhtPsWDhZ6tw!GO8R3ZuhZ1VFpLzHNMxNgLQh_MnTqOf0QfhvgAVIMg15J6EFXJwPIClI9Xn3AWrYrSg0AGwenDxAngczRdpu-U1X$[download[.]01[.]org])
>compiler: clang version 21.0.0git (https://urldefense.com/v3/__https://github.com/llvm/llvm-project__;!!FtrhtPsWDhZ6tw!GO8R3ZuhZ1VFpLzHNMxNgLQh_MnTqOf0QfhvgAVIMg15J6EFXJwPIClI9Xn3AWrYrSg0AGwenDxAngczRVrN-XjA$[github[.]com] 01c97b4953e87ae455bd4c41e3de3f0f0f29c61c)
>
>If you fix the issue in a separate patch/commit (i.e. not just a new version of
>the same patch/commit), kindly add following tags
>| Reported-by: kernel test robot <lkp@...el.com>
>| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
>| Closes: https://urldefense.com/v3/__https://lore.kernel.org/r/202507130115.7g0XWB2E-lkp@intel.com/__;!!FtrhtPsWDhZ6tw!GO8R3ZuhZ1VFpLzHNMxNgLQh_MnTqOf0QfhvgAVIMg15J6EFXJwPIClI9Xn3AWrYrSg0AGwenDxAngczRW3ZbDKk$[lore[.]kernel[.]org]
>
>smatch warnings:
>drivers/iio/imu/inv_icm45600/inv_icm45600_gyro.c:121 inv_icm45600_gyro_update_scan_mode() error: uninitialized symbol 'sleep'.
>drivers/iio/imu/inv_icm45600/inv_icm45600_accel.c:123 inv_icm45600_accel_update_scan_mode() error: uninitialized symbol 'sleep'.
>
>vim +/sleep +121 drivers/iio/imu/inv_icm45600/inv_icm45600_gyro.c
>
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 93 static int inv_icm45600_gyro_update_scan_mode(struct iio_dev *indio_dev,
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 94 const unsigned long *scan_mask)
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 95 {
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 96 struct inv_icm45600_state *st = iio_device_get_drvdata(indio_dev);
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 97 struct inv_icm45600_sensor_state *gyro_st = iio_priv(indio_dev);
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 98 struct inv_icm45600_sensor_conf conf = INV_ICM45600_SENSOR_CONF_INIT;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 99 unsigned int fifo_en = 0;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 100 unsigned int sleep;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 101 int ret;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 102
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 103 scoped_guard(mutex, &st->lock) {
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 104 if (*scan_mask & BIT(INV_ICM45600_GYRO_SCAN_TEMP))
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 105 fifo_en |= INV_ICM45600_SENSOR_TEMP;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 106
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 107 if (*scan_mask & (BIT(INV_ICM45600_GYRO_SCAN_X) |
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 108 BIT(INV_ICM45600_GYRO_SCAN_Y) |
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 109 BIT(INV_ICM45600_GYRO_SCAN_Z))) {
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 110 /* enable gyro sensor */
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 111 conf.mode = gyro_st->power_mode;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 112 ret = inv_icm45600_set_gyro_conf(st, &conf, &sleep);
>
>sleep isn't necessarily set if nothing changed.
Hello Dan,
Thanks for the tip,
I'll fix this following Andy's recommandation.
>
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 113 if (ret)
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 114 return ret;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 115 fifo_en |= INV_ICM45600_SENSOR_GYRO;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 116 }
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 117 /* update data FIFO write */
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 118 ret = inv_icm45600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 119 }
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 120 /* sleep required time */
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 @121 if (sleep)
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 122 msleep(sleep);
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 123
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 124 return ret;
>1fb5c2bf7348d0 Remi Buisson 2025-07-10 125 }
>
>--
>0-DAY CI Kernel Test Service
>https://urldefense.com/v3/__https://github.com/intel/lkp-tests/wiki__;!!FtrhtPsWDhZ6tw!GO8R3ZuhZ1VFpLzHNMxNgLQh_MnTqOf0QfhvgAVIMg15J6EFXJwPIClI9Xn3AWrYrSg0AGwenDxAngczRadkLqZM$[github[.]com]
>
>
Powered by blists - more mailing lists