linux-kernel - Re: [PATCH v2 1/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: add DSI & DSI PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8400355-d59e-44ad-8f69-af068a6ee85c@ti.com>
Date: Tue, 15 Jul 2025 15:16:50 +0530
From: Jayesh Choudhary <j-choudhary@...com>
To: Vignesh Raghavendra <vigneshr@...com>, <nm@...com>,
        <devicetree@...r.kernel.org>
CC: <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devarsht@...com>, <u-kumar1@...com>
Subject: Re: [PATCH v2 1/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: add
 DSI & DSI PHY

Hello Vignesh,

On 26/06/25 11:56, Vignesh Raghavendra wrote:
> Hi
> 
> On 24/06/25 13:56, Jayesh Choudhary wrote:
>> Add DT nodes for DPI to DSI Bridge and DSI Phy.
>> The DSI bridge is Cadence DSI and the PHY is a
>> Cadence DPHY with TI wrapper.
>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
>> ---
>>   .../dts/ti/k3-j784s4-j742s2-main-common.dtsi  | 37 +++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
>> index 363d68fec387..2413c4913a8b 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
>> @@ -2517,6 +2517,43 @@ watchdog18: watchdog@...0000 {
>>   		status = "reserved";
>>   	};
>>   
>> +	dphy_tx0: phy@...0000 {
>> +		compatible = "ti,j721e-dphy";
>> +		reg = <0x0 0x04480000 0x0 0x1000>;
> 
> Follow the convention of the file. Use:
> 
> 		reg = <0x00 0x04480000 0x00 0x1000>;

Okay I will add padding.
Will add it to 4th field as well as I am seeing it in some
nodes:

reg = <0x00 0x04480000 0x00 0x00001000>;

> 
> Please fix throughout the series.


Okay.

> 
>> +		clocks = <&k3_clks 402 20>, <&k3_clks 402 3>;
>> +		clock-names = "psm", "pll_ref";
>> +		#phy-cells = <0>;
>> +		power-domains = <&k3_pds 402 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 402 3>;
>> +		assigned-clock-parents = <&k3_clks 402 4>;
>> +		assigned-clock-rates = <19200000>;
>> +		status = "disabled";
>> +	};
>> +
>> +	dsi0: dsi@...0000 {
>> +		compatible = "ti,j721e-dsi";
>> +		reg = <0x0 0x04800000 0x0 0x100000>, <0x0 0x04710000 0x0 0x100>;
>> +		clocks = <&k3_clks 215 2>, <&k3_clks 215 5>;
>> +		clock-names = "dsi_p_clk", "dsi_sys_clk";
>> +		power-domains = <&k3_pds 215 TI_SCI_PD_EXCLUSIVE>;
> 
>> +		interrupt-parent = <&gic500>;
> 
> This is implied and can be dropped.

Will drop.

Warm Regards,
Jayesh

> 
>> +		interrupts = <GIC_SPI 600 IRQ_TYPE_LEVEL_HIGH>;
>> +		phys = <&dphy_tx0>;
>> +		phy-names = "dphy";
>> +		status = "disabled";
>> +
>> +		dsi0_ports: ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			port@0 {
>> +				reg = <0>;
>> +			};
>> +			port@1 {
>> +				reg = <1>;
>> +			};
>> +		};
>> +	};
>> +
>>   	mhdp: bridge@...0000 {
>>   		compatible = "ti,j721e-mhdp8546";
>>   		reg = <0x0 0xa000000 0x0 0x30a00>,
>