linux-kernel - Re: [PATCH] cxl: Remove core/acpi.c and cxl core dependency on ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHYp9g0H4efRRIZ5@rric.localdomain>
Date: Tue, 15 Jul 2025 12:14:14 +0200
From: Robert Richter <rrichter@....com>
To: Dave Jiang <dave.jiang@...el.com>
Cc: Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org
Subject: Re: [PATCH] cxl: Remove core/acpi.c and cxl core dependency on ACPI

On 14.07.25 16:51:40, Dave Jiang wrote:
> 
> 
> On 7/14/25 2:36 PM, Dave Jiang wrote:
> > 
> > 
> > On 7/11/25 8:15 AM, Robert Richter wrote:
> >> From Dave [1]:
> >>
> >> """
> >> It was a mistake to introduce core/acpi.c and putting ACPI dependency on
> >> cxl_core when adding the extended linear cache support.
> >> """
> >>
> >> Current implementation calls hmat_get_extended_linear_cache_size() of
> >> the ACPI subsystem. That external reference causes issue running
> >> cxl_test as there is no way to "mock" that function and ignore it when
> >> using cxl test.
> >>
> >> Instead of working around that using cxlrd ops and extensively
> >> expanding cxl_test code [1], just move HMAT calls out of the core
> >> module to cxl_acpi. Implement this by adding a @cache_size member to
> >> struct cxl_root_decoder. During initialization the cache size is
> >> determined and added to the root decoder object in cxl_acpi. Later on
> >> in cxl_core the cache_size parameter is used to setup extended linear
> >> caching.
> >>
> >> [1] https://patch.msgid.link/20250610172938.139428-1-dave.jiang@intel.com
> >>
> >> Cc: Dave Jiang <dave.jiang@...el.com>
> >> Signed-off-by: Robert Richter <rrichter@....com>
> > 
> > Applied to cxl/next
> > 4211a8a86304a53719931e7d19efc102eb8ede24
> 
> Actually 8d41af0d378dc0832d64b71bb0f71098c23dd1c4
> Had to add the removal of core/acpi.o entry from tools/testing/cxl/Kbuild

Right, this was missing. Thanks,

-Robert