linux-kernel - Re: [PATCH] selftests/mm: refactor common code and improve test skipping in guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250715110507.5383-1-lianux.mm@gmail.com>
Date: Tue, 15 Jul 2025 19:05:07 +0800
From: wang lian <lianux.mm@...il.com>
To: lorenzo.stoakes@...cle.com
Cc: Liam.Howlett@...cle.com,
	akpm@...ux-foundation.org,
	brauner@...nel.org,
	broonie@...nel.org,
	david@...hat.com,
	gkwang@...x-info.com,
	jannh@...gle.com,
	lianux.mm@...il.com,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	linux-mm@...ck.org,
	p1ucky0923@...il.com,
	ryncsn@...il.com,
	shuah@...nel.org,
	sj@...nel.org,
	vbabka@...e.cz,
	zijing.zhang@...ton.me,
	ziy@...dia.com
Subject: Re: [PATCH] selftests/mm: refactor common code and improve test skipping in guard_region

> On Mon, Jul 14, 2025 at 03:44:28PM +0200, David Hildenbrand wrote:
> > On 14.07.25 15:39, Mark Brown wrote:
> > > On Mon, Jul 14, 2025 at 09:00:09PM +0800, wang lian wrote:
> > >
> > > > Move the generic `FORCE_READ` macro from `guard-regions.c` to the shared
> > > > `vm_util.h` header to promote code reuse.
> > > >
> > > > In `guard-regions.c`, replace `ksft_exit_skip()` with the `SKIP()` macro
> > > > to ensure only the current test is skipped on permission failure, instead
> > > > of terminating the entire test binary.
> > >
> > > These two changes look fine but they're not really related so should be
> > > separate patches.  Looking briefly at guard-regions.c I see a bunch more
> > > use of ksft_exit_ functions that ought to be fixed as well, but your fix
> > > is good.
> >
> > The FORCE_READ() could be factored out separately, and as part of the same
> > patch, replace the "asm volatile("" : "+r" (XXX));" usage in
> >
> > * cow.c
> > * hugetlb-madvise.c
> > * migration.c
> > * pagemap_ioctl.c
> > * split_huge_page_test.c

> Wang - Feel free to put my Reviewed-by in any such series assuming you do a
> straight up replace.

> >
> > --
> > Cheers,
> >
> > David / dhildenb
> > 

> Cheers, Lorenzo

Thanks all for the helpful feedback and encouragement!

I'll prepare  include the straightforward replacements in the other tests as suggested.


Thanks again!

Best regards,
wang lian