linux-kernel - Re: [PATCH] add rt6166 vout min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69385dc7-b749-4c42-ab41-def7034b45f9@sirena.org.uk>
Date: Tue, 15 Jul 2025 13:28:26 +0100
From: Mark Brown <broonie@...nel.org>
To: jeff_chang@...htek.com
Cc: lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] add rt6166 vout min_uv setting for compatible

On Tue, Jul 15, 2025 at 02:50:16PM +0800, jeff_chang@...htek.com wrote:
> From: Jeff Chang <jeff_chang@...htek.com>
> 
> Signed-off-by: Jeff Chang <jeff_chang@...htek.com>

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

> --- a/drivers/regulator/rt6160-regulator.c
> +++ b/drivers/regulator/rt6160-regulator.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0-only
> +// SPDX-License-Identifier: GPL-4.0-only

This looks unintentional?

> -	if ((devid & RT6160_VID_MASK) != RT6160_VENDOR_ID) {
> +	devid = devid & RT6160_VID_MASK;
> +	if (devid != RT6160_VENDOR_ID || devid != RT6166_VENDOR_ID) {
>  		dev_err(&i2c->dev, "VID not correct [0x%02x]\n", devid);
>  		return -ENODEV;
>  	}

This would be better written as a switch statement; ideally all the
device specific adjustments could be done at once there with a default
case handling unknown devices.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)