linux-kernel - Re: [PATCH] [v2] scsi: qla2xxx: avoid stack frame size warning in qla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175193808975.2586181.3549891126119956725.b4-ty@oracle.com>
Date: Mon, 14 Jul 2025 21:53:48 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        Arnd Bergmann <arnd@...nel.org>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        Arnd Bergmann <arnd@...db.de>, Quinn Tran <qutran@...vell.com>,
        Himanshu Madhani <himanshu.madhani@...cle.com>,
        "Dr. David Alan Gilbert" <linux@...blig.org>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] scsi: qla2xxx: avoid stack frame size warning in qla_dfs

On Fri, 20 Jun 2025 19:32:22 +0200, Arnd Bergmann wrote:

> The qla2x00_dfs_tgt_port_database_show() function constructs a fake
> fc_port_t object on the stack, which depending on the configuration
> is large enough to exceed the stack size warning limit:
> 
> drivers/scsi/qla2xxx/qla_dfs.c:176:1: error: stack frame size (1392) exceeds limit (1280) in 'qla2x00_dfs_tgt_port_database_show' [-Werror,-Wframe-larger-than]
> 
> Rework this function to no longer need the structure but instead
> call a custom helper function that just prints the data directly
> from the port_database_24xx structure.
> 
> [...]

Applied to 6.17/scsi-queue, thanks!

[1/1] scsi: qla2xxx: avoid stack frame size warning in qla_dfs
      https://git.kernel.org/mkp/scsi/c/6243146bb019

-- 
Martin K. Petersen	Oracle Linux Engineering