linux-kernel - Re: [PATCH] media: atomisp: fix trailing block comment style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3P287MB1829790FCBF0CFF1F06585728B57A@PN3P287MB1829.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 15 Jul 2025 13:11:34 +0000
From: Tarang Raval <tarang.raval@...iconsignals.io>
To: Michelle Jin <shjy180909@...il.com>, "andy@...nel.org" <andy@...nel.org>,
	"hansg@...nel.org" <hansg@...nel.org>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>
CC: "lkcamp/patches@...ts.sr.ht" <lkcamp/patches@...ts.sr.ht>,
	"koike@...lia.com" <koike@...lia.com>
Subject: Re: [PATCH] media: atomisp: fix trailing block comment style

Hi Michelle,

> Fixes a checkpatch.pl warning regarding block comment formatting.
> 
> The trailing '*/' on line 78 was moved to a separate line to conform to
> Linux kernel coding style guidelines.
> 
> Signed-off-by: Michelle Jin <shjy180909@...il.com>
> ---
>  .../media/atomisp/include/linux/atomisp_platform.h   | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> index 6146555fe9cf..95e18c7ddc13 100644
> --- a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> +++ b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> @@ -73,9 +73,11 @@ enum atomisp_input_format {
>         /* CSI2-MIPI specific format: YUV data.
>          */

It would be better as:
/* CSI2-MIPI specific format: YUV data. */

You could further improve readability by converting some 
multi-line comments into single-line comments, where 
appropriate.

>         ATOMISP_INPUT_FORMAT_YUV420_8_SHIFT,  /* YUV420 8-bit (Chroma Shifted
> -                                                Pixel Sampling) */
> +                                              * Pixel Sampling)
> +                                              */
>         ATOMISP_INPUT_FORMAT_YUV420_10_SHIFT, /* YUV420 8-bit (Chroma Shifted
> -                                                Pixel Sampling) */
> +                                              * Pixel Sampling)
> +                                              */
> 
>         /* CSI2-MIPI specific format: Generic long packet data
>          */

same here

> @@ -119,10 +121,12 @@ struct atomisp_input_stream_info {
>         enum atomisp_input_stream_id stream;
>         u8 enable;
>         /* Sensor driver fills ch_id with the id
> -          of the virtual channel. */
> +        * of the virtual channel.
> +        */

Preferred line length is 80 columns, so I guess.
you can write it in a single line.

Best Regards,
Tarang