linux-kernel - Re: [PATCH net-next v7 1/7] netmem: introduce struct netmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250715020819.GA80407@system.software.com>
Date: Tue, 15 Jul 2025 11:08:19 +0900
From: Byungchul Park <byungchul@...com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Harry Yoo <harry.yoo@...cle.com>, Vlastimil Babka <vbabka@...e.cz>,
	willy@...radead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	kernel_team@...ynix.com, almasrymina@...gle.com,
	ilias.apalodimas@...aro.org, hawk@...nel.org,
	akpm@...ux-foundation.org, davem@...emloft.net,
	john.fastabend@...il.com, andrew+netdev@...n.ch,
	asml.silence@...il.com, toke@...hat.com, tariqt@...dia.com,
	edumazet@...gle.com, pabeni@...hat.com, saeedm@...dia.com,
	leon@...nel.org, ast@...nel.org, daniel@...earbox.net,
	david@...hat.com, lorenzo.stoakes@...cle.com,
	Liam.Howlett@...cle.com, rppt@...nel.org, surenb@...gle.com,
	mhocko@...e.com, horms@...nel.org, linux-rdma@...r.kernel.org,
	bpf@...r.kernel.org, vishal.moola@...il.com, hannes@...xchg.org,
	ziy@...dia.com, jackmanb@...gle.com
Subject: Re: [PATCH net-next v7 1/7] netmem: introduce struct netmem_desc
 mirroring struct page

On Mon, Jul 14, 2025 at 06:47:43PM -0700, Jakub Kicinski wrote:
> 
> On Mon, 14 Jul 2025 22:58:31 +0900 Harry Yoo wrote:
> > > > Could you please share your thoughts on why it's hard to judge them and
> > > > what's missing from the series, such as in the comments, changelog, or
> > > > the cover letter?
> 
> My main concern (as shared on earlier revisions) is the type hierarchy
> exposed to the drivers. Converting things back and forth or blindly
> downcasting to netmem and upcasting back to the CPU-readable type is
> no good.

I understand your concern.  I removed a lot of converting things but
left essencial things, that is inevitable to remove accessing the pp
fields through struct page.  Is it still not okay with v10 [1]?

There are some points under disscussion with Mina but I'm curious about
how you think about the direction changed.

[1] https://lore.kernel.org/all/20250714120047.35901-1-byungchul@sk.com/

	Byungchul