linux-kernel - Re: [PATCH v2 net-next] ipv6: mcast: Simplify mld_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHexpi793R81UrAt@fedora>
Date: Wed, 16 Jul 2025 14:05:26 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next] ipv6: mcast: Simplify
 mld_clear_{report|query}()

On Tue, Jul 15, 2025 at 08:07:09PM +0800, Yue Haibing wrote:
> Use __skb_queue_purge() instead of re-implementing it. Note that it uses
> kfree_skb_reason() instead of kfree_skb() internally, and pass
> SKB_DROP_REASON_QUEUE_PURGE drop reason to the kfree_skb tracepoint.
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
> v2: Add drop reason note
> ---
>  net/ipv6/mcast.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
> index 8aecdd85a6ae..36ca27496b3c 100644
> --- a/net/ipv6/mcast.c
> +++ b/net/ipv6/mcast.c
> @@ -845,21 +845,15 @@ static void mld_clear_delrec(struct inet6_dev *idev)
>  
>  static void mld_clear_query(struct inet6_dev *idev)
>  {
> -	struct sk_buff *skb;
> -
>  	spin_lock_bh(&idev->mc_query_lock);
> -	while ((skb = __skb_dequeue(&idev->mc_query_queue)))
> -		kfree_skb(skb);
> +	__skb_queue_purge(&idev->mc_query_queue);
>  	spin_unlock_bh(&idev->mc_query_lock);
>  }
>  
>  static void mld_clear_report(struct inet6_dev *idev)
>  {
> -	struct sk_buff *skb;
> -
>  	spin_lock_bh(&idev->mc_report_lock);
> -	while ((skb = __skb_dequeue(&idev->mc_report_queue)))
> -		kfree_skb(skb);
> +	__skb_queue_purge(&idev->mc_report_queue);
>  	spin_unlock_bh(&idev->mc_report_lock);
>  }
>  
> -- 
> 2.34.1
> 

Reviewed-by: Hangbin Liu <liuhangbin@...il.com>