linux-kernel - Re: [PATCH 1/4] hwmon: ina238: Fix inconsistent whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e6d8c2f-ab9a-495d-8b43-878dbc0451ee@roeck-us.net>
Date: Wed, 16 Jul 2025 08:52:22 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Jonas Rebmann <jre@...gutronix.de>, Jean Delvare <jdelvare@...e.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 Krzysztof Kozlowski <krzk@...nel.org>, devicetree@...r.kernel.org,
 kernel@...gutronix.de
Subject: Re: [PATCH 1/4] hwmon: ina238: Fix inconsistent whitespace

On 7/15/25 13:49, Jonas Rebmann wrote:
> Some purely cosmetic changes in ina238.c:
> 
>   - When aligning definitions, do so consistently with tab stop of 8.
>   - Use spaces instead of tabs around operators.
>   - Align wrapped lines.
> 
> Signed-off-by: Jonas Rebmann <jre@...gutronix.de>
> ---
>   drivers/hwmon/ina238.c | 30 +++++++++++++++---------------
>   1 file changed, 15 insertions(+), 15 deletions(-)
...
>   static struct i2c_driver ina238_driver = {
>   	.driver = {
> -		.name	= "ina238",
> +		.name = "ina238",

This was aligned with ".probe" below. Either leave it alone or change the tabs below as well.

Thanks,
Guenter


>   		.of_match_table = of_match_ptr(ina238_of_match),
>   	},
>   	.probe		= ina238_probe,
>