linux-kernel - Re: [PATCH] scsi: mpi3mr: Emit uevent on controller diagnostic fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30f8ea8d-79c4-4e5c-b354-51ad8146a61c@acm.org>
Date: Wed, 16 Jul 2025 08:51:04 -0700
From: Bart Van Assche <bvanassche@....org>
To: Salomon Dushimirimana <salomondush@...gle.com>,
 Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>,
 Kashyap Desai <kashyap.desai@...adcom.com>,
 Sumit Saxena <sumit.saxena@...adcom.com>,
 Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: mpi3mr-linuxdrv.pdl@...adcom.com, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: mpi3mr: Emit uevent on controller diagnostic fault

On 7/15/25 6:31 PM, Salomon Dushimirimana wrote:
> +	ioc_info(mrioc, "emitting fault exception uevent");

Is it really necessary to log that a uevent will be emitted?

> +exit:
> +	kfree(env);
> +}
Why an explicit kfree() call instead of adding __free(kfree) to
the declaration of "env"?

Thanks,

Bart.