linux-kernel - Re: [PATCH] riscv: dts: starfive: jh7110-common: add status power led node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff4021dd-69bc-45ae-a3d0-7f15be194717@freeshell.de>
Date: Wed, 16 Jul 2025 10:14:12 -0700
From: E Shattow <e@...eshell.de>
To: Conor Dooley <conor@...nel.org>
Cc: Emil Renner Berthing <kernel@...il.dk>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>, linux-riscv@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: add status power led
 node



On 7/16/25 08:28, Conor Dooley wrote:
> On Tue, Jul 15, 2025 at 09:04:54PM -0700, E Shattow wrote:
>> Add status power led node for StarFive VisionFive2 and variant boards.
>>
>> Signed-off-by: E Shattow <e@...eshell.de>
> 
> Again, I'll grab this too but it may be too late for 6.17.
> 
>> ---
>>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> index 4baeb981d4df..2eaf01775ef5 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> @@ -8,6 +8,7 @@
>>  #include "jh7110.dtsi"
>>  #include "jh7110-pinfunc.h"
>>  #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/leds/common.h>
>>  #include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
>>  
>>  / {
>> @@ -38,6 +39,14 @@ gpio-restart {
>>  		priority = <224>;
>>  	};
>>  
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		led_status_power: led-0 {
>> +			gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
>> +		};
>> +	};
>> +
>>  	pwmdac_codec: audio-codec {
>>  		compatible = "linux,spdif-dit";
>>  		#sound-dai-cells = <0>;
>>
>> base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
>> -- 
>> 2.50.0
>>

Ok sounds good to me. This is common on all JH7110 boards, but am not
sure if it is connected to anything on DeepComputing Framework 13 V01.

LED color varies yet there is an LED connected this way on variants I
could find a published schematic for:
- Milk-V Mars
- Pine64 Star64
- StarFive VisionFive2 1.2a
- StarFive VisionFive2 1.3b

Discussion about the OrangePi RV dts shows this to have the same
connection to an LED. I am putting together patches for adding Milk-V
Mars CM and Milk-V Mars CM Lite, tested successfully and listed on
schematics as well. Some early revision developer sample board
schematics for some of the above do not list RGPIO3 so assumed n/c and
no problem there.

If anyone out there can link to the FML13V01 schematic or confirm this
change does not break for users I'd appreciate that, for any follow-up
that might be needed per-board.

-E