linux-kernel - Re: [PATCH v6 2/3] eeprom: add driver for ST M24LR series RFID/NFC EEPROM chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250716142127.1664-1-abd.masalkhi@gmail.com>
Date: Wed, 16 Jul 2025 14:21:27 +0000
From: Abd-Alrhman Masalkhi <abd.masalkhi@...il.com>
To: gregkh@...uxfoundation.org
Cc: abd.masalkhi@...il.com,
	arnd@...db.de,
	christophe.jaillet@...adoo.fr,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	krzk+dt@...nel.org,
	linux-kernel@...r.kernel.org,
	luoyifan@...s.chinamobile.com,
	robh@...nel.org
Subject: Re: [PATCH v6 2/3] eeprom: add driver for ST M24LR series RFID/NFC EEPROM chips

On Wed, Jul 16, 2025 at 13:53 +0200, Greg KH wrote:
> On Sun, Jul 06, 2025 at 10:53:10AM +0000, Abd-Alrhman Masalkhi wrote:
>> +/**
>> + * m24lr_parse_le_value - Parse hex string and convert to little-endian binary
>> + * @buf:	Input string buffer (hex format)
>> + * @reg_size:	Size of the register in bytes (must be 1, 2, 4, or 8)
>> + * @output:	Output buffer to store the value in little-endian format
>> + *
>> + * Converts a hexadecimal string to a numeric value of the given register size
>> + * and writes it in little-endian byte order into the provided buffer.
>> + *
>> + * Return: 0 on success, or negative error code on failure
>> + */
>> +static __maybe_unused int m24lr_parse_le_value(const char *buf, u32 reg_size,
>> +					       u8 *output)
>
> Your __maybe_unused marker here hid the fact that it is NOT used
> anywhere in this driver :(
>
> Please remove this function as it's not needed.
>
> thanks,
>
> greg k-h

Hello Greg,

Thank you for the review!

It is done.

-- 
Best Regards,
Abd-Alrhman