linux-kernel - Re: [PATCH] ACPI: TAD: Replace sprintf with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gh2pARpomZnXiLegduYBczBG6ZGUSpzeo6RFb5XTwULg@mail.gmail.com>
Date: Wed, 16 Jul 2025 21:15:13 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Sukrut Heroorkar <hsukrut3@...il.com>
Cc: rafel@...nel.org, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	skhan@...uxfoundation.org, david.hunter.linux@...il.com
Subject: Re: [PATCH] ACPI: TAD: Replace sprintf with sysfs_emit

On Wed, Jul 16, 2025 at 2:36 PM Sukrut Heroorkar <hsukrut3@...il.com> wrote:
>
> Replace use of sprintf in *_show attributes with sysfs_emit for writing
> to sysfs. While the current implementation works, sysfs_emit helps prevent
> potential buffer overflows and aligns with kernel documentation
> Documentation/filesystems/sysfs.rst.
>
> Tested on an x86_64 system with acpi_tad built as a module:
> - Inserted patched acpi_tad.ko successfully
> - Verified /sys/devices/platform/ACPI000E:00/time and /caps are accessible
> - Confirmed correct output from 'cat' with no dmesg errors
>
> Signed-off-by: Sukrut Heroorkar <hsukrut3@...il.com>
> ---
>  drivers/acpi/acpi_tad.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpi_tad.c b/drivers/acpi/acpi_tad.c
> index 825c2a8acea4..91d7d90c47da 100644
> --- a/drivers/acpi/acpi_tad.c
> +++ b/drivers/acpi/acpi_tad.c
> @@ -233,7 +233,7 @@ static ssize_t time_show(struct device *dev, struct device_attribute *attr,
>         if (ret)
>                 return ret;
>
> -       return sprintf(buf, "%u:%u:%u:%u:%u:%u:%d:%u\n",
> +       return sysfs_emit(buf, "%u:%u:%u:%u:%u:%u:%d:%u\n",
>                        rt.year, rt.month, rt.day, rt.hour, rt.minute, rt.second,
>                        rt.tz, rt.daylight);
>  }
> @@ -428,7 +428,7 @@ static ssize_t caps_show(struct device *dev, struct device_attribute *attr,
>  {
>         struct acpi_tad_driver_data *dd = dev_get_drvdata(dev);
>
> -       return sprintf(buf, "0x%02X\n", dd->capabilities);
> +       return sysfs_emit(buf, "0x%02X\n", dd->capabilities);
>  }
>
>  static DEVICE_ATTR_RO(caps);
> --

Applied as 6.17 material, thanks!