linux-kernel - Re: Gentle ping: [PATCH v2 0/6] MIPS: Resolve build problems on decstation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHf8Uo2FEcRqus9T@alpha.franken.de>
Date: Wed, 16 Jul 2025 21:24:02 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: "Maciej W. Rozycki" <macro@...am.me.uk>
Cc: WangYuli <wangyuli@...ontech.com>, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org, zhanjun@...ontech.com,
	niecheng1@...ontech.com, guanwentao@...ontech.com
Subject: Re: Gentle ping: [PATCH v2 0/6] MIPS: Resolve build problems on
 decstation_64

On Mon, Jul 07, 2025 at 03:57:01PM +0100, Maciej W. Rozycki wrote:
> Hi WangYuli,
> 
> > This is a gentle ping.
> > 
> > I've addressed all the feedback from previous discussions and tried resending
> > multiple times, but haven't received any response
> 
>  Thank you for pinging.
> 
>  I've tried to verify your changes at run time and it's turned out that a 
> generic change to the serial communication subsystem made a while ago has 
> caused the port to become unbootable, and it now crashes early on in port 
> registration.

I'm hitting the same issue for IP22, my dirty hack to get serial console
back is

diff --git a/drivers/tty/serial/serial_base_bus.c b/drivers/tty/serial/serial_base_bus.c
index 5d1677f1b651..fccb0f1c3cc5 100644
--- a/drivers/tty/serial/serial_base_bus.c
+++ b/drivers/tty/serial/serial_base_bus.c
@@ -78,12 +78,14 @@ static int serial_base_device_init(struct uart_port *port,
 		return -EPROBE_DEFER;
 	}
 
+#if 0
 	if (type == &serial_ctrl_type)
 		return dev_set_name(dev, "%s:%d", dev_name(port->dev), ctrl_id);
 
 	if (type == &serial_port_type)
 		return dev_set_name(dev, "%s:%d.%d", dev_name(port->dev),
 				    ctrl_id, port_id);
+#endif
 
 	return -EINVAL;
 }

I'm not sure, if port->dev needs to be populated now for every serial
port or if there should be a check for port->dev == NULL in the code above...

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]