linux-kernel - Re: [PATCH v9] rust: kernel: add support for bits/genmask macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBDR0X23V1Z8.B3FYX0G7XTCZ@kernel.org>
Date: Wed, 16 Jul 2025 22:06:54 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Daniel Almeida" <daniel.almeida@...labora.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, <linux-kernel@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, "Alexandre Courbot" <acourbot@...dia.com>
Subject: Re: [PATCH v9] rust: kernel: add support for bits/genmask macros

On Wed Jul 16, 2025 at 9:49 PM CEST, Danilo Krummrich wrote:
> On Wed Jul 16, 2025 at 9:44 PM CEST, Daniel Almeida wrote:
>> I guess this is the same problem as u64: drivers will usually have either
>> i32s/u32s and this would require a cast.
>
> I don't understand this argument? We usualy use usize for such things, no?

I already thought in terms of the register!() macro, which deals with target
types for us anyways. Without that, you're right, u32 is better.