| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <603b8fb4-8d73-488b-928a-5b2e12e5993e@roeck-us.net>
Date: Wed, 16 Jul 2025 13:09:59 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Chiang Brian <chiang.brian@...entec.com>
Cc: jdelvare@...e.com, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, linux-hwmon@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685
On Thu, Jun 19, 2025 at 02:42:23PM +0800, Chiang Brian wrote:
> The TPS53685 is a fully AMD SVI3 compliant step down controller with
> trans-inductor voltage regulator(TLVR) topology support, dual channels,
> built-in non-volatile memory (NVM), PMBus interface, and full compatible
> with TI NexFET smart power stages.
>
> Add support for it to the tps53679 driver.
>
> Signed-off-by: Chiang Brian <chiang.brian@...entec.com>
Applied.
Thanks,
Guenter
> ---
> v9 -> v10:
> - Fix the inconsistent indenting in switch case with tab instead of space
> - Run the smatch kchecker to confirm
> - Link to v9: https://lore.kernel.org/all/20250610102556.236300-3-chiang.brian@inventec.com/
>
> v8 -> v9:
> - Wrap commit message body at 75 columns
> - Fix the alignment to match open parenthesis
> - Link to v8: https://lore.kernel.org/all/20250602042454.184643-3-chiang.brian@inventec.com/
>
> v7 -> v8:
> - Convert the type of device_id in tps53679_identify_multiphase() from int to char *
> - Run make.cross with ARCH i386
> - Link to v7: https://lore.kernel.org/all/20250515081449.1433772-3-chiang.brian@inventec.com/
>
> v6 -> v7:
> - Modify the type of device_id from u16 to char *
> - Run make.cross with ARCH nios2, powerpc, and riscv
> - Link to v6: https://lore.kernel.org/all/20250424132538.2004510-2-chiang.brian@inventec.corp-partner.google.com/
>
> v5 -> v6:
> - Add information about tps53685 into tps53679.rst
> - Add additional flags when identifing the chip as tps53685
> - Adjust length once returned device id is terminated by null character
> - Link to v5: https://lore.kernel.org/all/20250314033040.3190642-1-chiang.brian@inventec.com/
>
> v4 -> v5:
> - document the compatible of tps53685 into dt-bindings
> - add the buffer length as argument for %*ph
> - Add Changelog
> - Link to v4: https://lore.kernel.org/all/CAJCfHmW61d2jd_tYpNEqBG_Z58bEnVKAmsvhrEP1zXQoXqrUVw@mail.gmail.com/
>
> v3 -> v4:
> - Add length comparison into the comparison of "id",or it may be true when the substring of "id" matches device id.
> - Restore `return 0;` in `tps53679_identify_chip()`
> - Link to v3: https://lore.kernel.org/all/CAJCfHmVyaDPh0_ThPjhBP0zMO1oE1AR=4=Zsa0cMPXU3J4v6dw@mail.gmail.com/
>
> v2 -> v3:
> - Remove the length comparsion in the comparison of "id".
> - Link to v2: https://lore.kernel.org/all/CAJCfHmUteFM+nUZWBWvmwFjALg1QUL5r+=syU1HmYTL1ewQWqA@mail.gmail.com/
>
> v1 -> v2:
> - Modify subject and description to meet requirements
> - Add "tps53685" into enum chips with numeric order
> - Modify the content of marco "TPS53681_DEVICE_ID" from 0x81 to "\x81"
> - Add marco "TPS53685_DEVICE_ID" with content "TIShP"
> - Modify the type of "id" from u16 to char* in `tps53679_identify_chip()`
> - Modify the comparison of "id". It will be true if the string "id" matches device ID and compare with type char*,
> - Add the length comparsion into the comparison of "id".
> - Modify "len" as return code in `tps53679_identify_chip()`
> - Output device error log with %*ph, instead of 0x%x\n"
> - Use existing tps53679_identify_multiphase() with argument "TPS53685_DEVICE_ID" in tps53685_identify() rather than creating one tps53685_identify_multiphase()
> - Link to v1: https://lore.kernel.org/all/CAJCfHmVy3O4-nz2_PKF7TcXYr+HqTte1-bdUWLBmV7JOS7He1g@mail.gmail.com/
>
> Documentation/hwmon/tps53679.rst | 8 +++++++
> drivers/hwmon/pmbus/tps53679.c | 37 ++++++++++++++++++++++++++------
> 2 files changed, 39 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/hwmon/tps53679.rst b/Documentation/hwmon/tps53679.rst
> index 3b9561648c24..dd5e4a37375d 100644
> --- a/Documentation/hwmon/tps53679.rst
> +++ b/Documentation/hwmon/tps53679.rst
> @@ -43,6 +43,14 @@ Supported chips:
>
> Datasheet: https://www.ti.com/lit/gpn/TPS53681
>
> + * Texas Instruments TPS53685
> +
> + Prefix: 'tps53685'
> +
> + Addresses scanned: -
> +
> + Datasheet: https://www.ti.com/lit/gpn/TPS53685
> +
> * Texas Instruments TPS53688
>
> Prefix: 'tps53688'
> diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c
> index 63524dff5e75..ca2bfa25eb04 100644
> --- a/drivers/hwmon/pmbus/tps53679.c
> +++ b/drivers/hwmon/pmbus/tps53679.c
> @@ -16,7 +16,7 @@
> #include "pmbus.h"
>
> enum chips {
> - tps53647, tps53667, tps53676, tps53679, tps53681, tps53688
> + tps53647, tps53667, tps53676, tps53679, tps53681, tps53685, tps53688
> };
>
> #define TPS53647_PAGE_NUM 1
> @@ -31,7 +31,8 @@ enum chips {
> #define TPS53679_PROT_VR13_5MV 0x07 /* VR13.0 mode, 5-mV DAC */
> #define TPS53679_PAGE_NUM 2
>
> -#define TPS53681_DEVICE_ID 0x81
> +#define TPS53681_DEVICE_ID "\x81"
> +#define TPS53685_DEVICE_ID "TIShP"
>
> #define TPS53681_PMBUS_REVISION 0x33
>
> @@ -86,10 +87,12 @@ static int tps53679_identify_phases(struct i2c_client *client,
> }
>
> static int tps53679_identify_chip(struct i2c_client *client,
> - u8 revision, u16 id)
> + u8 revision, char *id)
> {
> u8 buf[I2C_SMBUS_BLOCK_MAX];
> int ret;
> + int buf_len;
> + int id_len;
>
> ret = pmbus_read_byte_data(client, 0, PMBUS_REVISION);
> if (ret < 0)
> @@ -102,8 +105,14 @@ static int tps53679_identify_chip(struct i2c_client *client,
> ret = i2c_smbus_read_block_data(client, PMBUS_IC_DEVICE_ID, buf);
> if (ret < 0)
> return ret;
> - if (ret != 1 || buf[0] != id) {
> - dev_err(&client->dev, "Unexpected device ID 0x%x\n", buf[0]);
> +
> + /* Adjust length if null terminator if present */
> + buf_len = (buf[ret - 1] != '\x00' ? ret : ret - 1);
> +
> + id_len = strlen(id);
> +
> + if (buf_len != id_len || strncmp(id, buf, id_len)) {
> + dev_err(&client->dev, "Unexpected device ID: %*ph\n", ret, buf);
> return -ENODEV;
> }
> return 0;
> @@ -117,7 +126,7 @@ static int tps53679_identify_chip(struct i2c_client *client,
> */
> static int tps53679_identify_multiphase(struct i2c_client *client,
> struct pmbus_driver_info *info,
> - int pmbus_rev, int device_id)
> + int pmbus_rev, char *device_id)
> {
> int ret;
>
> @@ -138,6 +147,16 @@ static int tps53679_identify(struct i2c_client *client,
> return tps53679_identify_mode(client, info);
> }
>
> +static int tps53685_identify(struct i2c_client *client,
> + struct pmbus_driver_info *info)
> +{
> + info->func[1] |= PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN |
> + PMBUS_HAVE_STATUS_INPUT;
> + info->format[PSC_VOLTAGE_OUT] = linear;
> + return tps53679_identify_chip(client, TPS53681_PMBUS_REVISION,
> + TPS53685_DEVICE_ID);
> +}
> +
> static int tps53681_identify(struct i2c_client *client,
> struct pmbus_driver_info *info)
> {
> @@ -263,6 +282,10 @@ static int tps53679_probe(struct i2c_client *client)
> info->identify = tps53681_identify;
> info->read_word_data = tps53681_read_word_data;
> break;
> + case tps53685:
> + info->pages = TPS53679_PAGE_NUM;
> + info->identify = tps53685_identify;
> + break;
> default:
> return -ENODEV;
> }
> @@ -277,6 +300,7 @@ static const struct i2c_device_id tps53679_id[] = {
> {"tps53676", tps53676},
> {"tps53679", tps53679},
> {"tps53681", tps53681},
> + {"tps53685", tps53685},
> {"tps53688", tps53688},
> {}
> };
> @@ -289,6 +313,7 @@ static const struct of_device_id __maybe_unused tps53679_of_match[] = {
> {.compatible = "ti,tps53676", .data = (void *)tps53676},
> {.compatible = "ti,tps53679", .data = (void *)tps53679},
> {.compatible = "ti,tps53681", .data = (void *)tps53681},
> + {.compatible = "ti,tps53685", .data = (void *)tps53685},
> {.compatible = "ti,tps53688", .data = (void *)tps53688},
> {}
> };
Powered by blists - more mailing lists