linux-kernel - Re: [PATCH v2 1/1] nvmet: pci-epf: Do not complete commands twice if nvmet_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fee4f767-301b-4650-8607-28fce17924ad@kernel.org>
Date: Thu, 17 Jul 2025 07:42:12 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Chaitanya Kulkarni <chaitanyak@...dia.com>,
 Rick Wertenbroek <rick.wertenbroek@...il.com>
Cc: "rick.wertenbroek@...g-vd.ch" <rick.wertenbroek@...g-vd.ch>,
 "alberto.dassatti@...g-vd.ch" <alberto.dassatti@...g-vd.ch>,
 "stable@...r.kernel.org" <stable@...r.kernel.org>,
 Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Keith Busch <kbusch@...nel.org>,
 "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>
Subject: Re: [PATCH v2 1/1] nvmet: pci-epf: Do not complete commands twice if
 nvmet_req_init() fails

On 7/17/25 06:56, Chaitanya Kulkarni wrote:
> Good catch, looks good, I wish we have tests for this part of target
> to it will get tested on regular basis, not the requirement, just
> a thought.

qemu does not have a PCI endpoint capable controller device and you cannot link
2 VMs to communicate over PCIe (one VM as host the other as endpoint). So unless
you get a PCIe-endpoint capable board, you cannot run this driver easily.

We can add a blktest case for sending an unsupported command though. That is
easy to do. But FYI, right now, running blktest/nvme group against a pci-epf
device, we get a hang... Shin'ichiro is looking into that.

-- 
Damien Le Moal
Western Digital Research