linux-kernel - Re: [net PatchV2] Octeontx2-vf: Fix max packet length errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250716162417.1d691576@kernel.org>
Date: Wed, 16 Jul 2025 16:24:17 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hariprasad Kelam <hkelam@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Sunil Goutham
 <sgoutham@...vell.com>, Geetha sowjanya <gakula@...vell.com>, "Subbaraya
 Sundeep" <sbhatta@...vell.com>, Bharat Bhushan <bbhushan2@...vell.com>,
 "Andrew Lunn" <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Tomasz Duszynski <tduszynski@...vell.com>, Simon
 Horman <horms@...nel.org>
Subject: Re: [net PatchV2] Octeontx2-vf: Fix max packet length errors

On Tue, 15 Jul 2025 16:43:51 +0530 Hariprasad Kelam wrote:
> +	netdev_stats_to_stats64(stats, &netdev->stats);
> +
>  	otx2_get_dev_stats(pfvf);
>  
>  	dev_stats = &pfvf->hw.dev_stats;
> @@ -149,7 +151,7 @@ void otx2_get_stats64(struct net_device *netdev,
>  
>  	stats->tx_bytes = dev_stats->tx_bytes;
>  	stats->tx_packets = dev_stats->tx_frames;
> -	stats->tx_dropped = dev_stats->tx_drops;
> +	stats->tx_dropped += dev_stats->tx_drops;

Please don't add new uses of netdev->stats.

	struct net_device_stats	stats; /* not used by modern drivers */
-- 
pw-bot: cr