linux-kernel - Re: [PATCH v5 2/3] hwmon: (cros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6286473-31a1-4f16-9c2f-8a39534c22bb@roeck-us.net>
Date: Wed, 16 Jul 2025 16:59:19 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Sung-Chi Li <lschyi@...omium.org>
Cc: Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
	Thomas Weißschuh <linux@...ssschuh.net>,
	Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
	Thomas Weißschuh <thomas@...ssschuh.net>,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
	Sung-Chi Li <lschyi@...gle.com>
Subject: Re: [PATCH v5 2/3] hwmon: (cros_ec) add PWM control over fans

On Fri, Jun 20, 2025 at 02:49:13PM +0800, Sung-Chi Li wrote:
> From: Sung-Chi Li <lschyi@...omium.org>
> 
> Newer EC firmware supports controlling fans through host commands, so
> adding corresponding implementations for controlling these fans in the
> driver for other kernel services and userspace to control them.
> 
> The driver will first probe the supported host command versions (get and
> set of fan PWM values, get and set of fan control mode) to see if the
> connected EC fulfills the requirements of controlling the fan, then
> exposes corresponding sysfs nodes for userspace to control the fan with
> corresponding read and write implementations.
> As EC will automatically change the fan mode to auto when the device is
> suspended, the power management hooks are added as well to keep the fan
> control mode and fan PWM value consistent during suspend and resume. As
> we need to access the hwmon device in the power management hook, update
> the driver by storing the hwmon device in the driver data as well.
> 
> Signed-off-by: Sung-Chi Li <lschyi@...omium.org>
> Acked-by: Thomas Weißschuh <linux@...ssschuh.net>

Please run checkpatch --strict on your patches and fix what it reports.

Guenter