linux-kernel - Re: [PATCH 1/3] staging: sm750fb: Fix const declaration for g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7f17f72-d086-4ab2-a22d-33f0ea125f54@suswa.mountain>
Date: Wed, 16 Jul 2025 07:18:23 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ignacio Peña <ignacio.pena87@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: sm750fb: Fix const declaration for g_fbmode
 array

On Tue, Jul 15, 2025 at 08:55:51PM -0400, Ignacio Peña wrote:
> The g_fbmode array should be declared as const pointer to const
> string as its contents never change.

Try compiling this code.  The contents do change.

There are a few other issues as well.  Try running checkpatch on your
patch.  Also there is a specific format for v2 patches
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter