linux-kernel - Re: [PATCH] spi: intel: Allow writeable MTD partition with module param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507161228.D92rDToS-lkp@intel.com>
Date: Wed, 16 Jul 2025 13:13:51 +0800
From: kernel test robot <lkp@...el.com>
To: Jakub Czapiga <czapiga@...gle.com>, Mark Brown <broonie@...nel.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: oe-kbuild-all@...ts.linux.dev, Konrad Adamczyk <konrada@...gle.com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jakub Czapiga <czapiga@...gle.com>
Subject: Re: [PATCH] spi: intel: Allow writeable MTD partition with module
 param

Hi Jakub,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on broonie-sound/for-next westeri-thunderbolt/next linus/master v6.16-rc6 next-20250715]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jakub-Czapiga/spi-intel-Allow-writeable-MTD-partition-with-module-param/20250715-175230
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20250715095007.896620-1-czapiga%40google.com
patch subject: [PATCH] spi: intel: Allow writeable MTD partition with module param
config: arc-randconfig-001-20250716 (https://download.01.org/0day-ci/archive/20250716/202507161228.D92rDToS-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250716/202507161228.D92rDToS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507161228.D92rDToS-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/spi/spi-intel.c:195:34: error: expected ')' before string constant
     195 |         ignore_protection_status,
         |                                  ^
         |                                  )
     196 |         "Do not block SPI flash chip write access even if it is write-protected (default=0)");
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +195 drivers/spi/spi-intel.c

   188	
   189	static bool writeable;
   190	module_param(writeable, bool, 0);
   191	MODULE_PARM_DESC(writeable, "Enable write access to SPI flash chip (default=0)");
   192	static bool ignore_protection_status;
   193	module_param(ignore_protection_status, bool, 0);
   194	MODULE_PARAM_DESC(
 > 195		ignore_protection_status,
   196		"Do not block SPI flash chip write access even if it is write-protected (default=0)");
   197	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki