lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250716072228-2dc39361-80b4-4603-8c20-4670a41e06ec@linutronix.de>
Date: Wed, 16 Jul 2025 07:30:46 +0200
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: Al Viro <viro@...iv.linux.org.uk>, 
	Luis Chamberlain <mcgrof@...nel.org>
Cc: Kees Cook <kees@...nel.org>, Christian Brauner <brauner@...nel.org>, 
	Jan Kara <jack@...e.cz>, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 06/15] fs,fork,exit: export symbols necessary for
 KUnit UAPI support

On Mon, Jul 14, 2025 at 07:52:28AM +0200, Thomas Weißschuh wrote:
> On Fri, Jul 11, 2025 at 04:44:23PM +0100, Al Viro wrote:

(...)

> > On Fri, Jul 11, 2025 at 12:35:59PM +0200, Thomas Weißschuh wrote:
> > > could you take a look at these new symbol exports?
> > 
> > > > +EXPORT_SYMBOL_GPL_FOR_MODULES(put_filesystem, "kunit-uapi");
> > 
> > What's that one for???
> 
> What are you referring to?

Reading this again you probably asked why put_filesystem() is exported.

As I see it, that should be called after being done with the return value of
get_fs_type(). Not that it does anything for the always built-in ramfs.
The alternatives I see are a commented-out variant with an explanation or
making put_filesystem() into an inline function.


Thomas

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ