linux-kernel - Re: Are LED functions strings or uint32 in Documentation/devicetree/bindings/leds/common.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6e4eb98-f535-4fa5-af3e-5d144275b05a@freeshell.de>
Date: Tue, 15 Jul 2025 22:38:44 -0700
From: E Shattow <e@...eshell.de>
To: Pavel Machek <pavel@....cz>
Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 linux-leds@...r.kernel.org
Subject: Re: Are LED functions strings or uint32 in
 Documentation/devicetree/bindings/leds/common.yaml



On 7/15/25 22:13, Pavel Machek wrote:
> Hi!
> 
>> Documentation/devicetree/bindings/leds/common.yaml [1] describes a
>> uint32 but the $ref is for a string, for "function". What's going on
>> there? Also what is the reasoning for that sort ordering [2] in the
>> examples, are we saying that gpios is like a register and function or
>> default-state is a kind of status?
>>
>> 1:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/common.yaml
>>
> 
> You may want to cc devicetree people and linux-leds mailing list.
> 
> Take a look at include/dt-bindings/leds/common.h, LED_FUNCTION_PANIC
> (for example) is a string, so documentation looks consistent to me.
> 
> BR,
> 								Pavel

Hi Pavel, thanks for the correction. That makes sense to me now, it is
more of a function name than a function enum.

Question about the dts examples' sort ordering remains? I try to follow
the devicetree code style document but I must get confused too easily :-)

Cheers,

-E

CC: devicetree, linux-leds