[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <710b546f-f898-4b20-8302-db0de69a3d80@ti.com>
Date: Wed, 16 Jul 2025 11:12:22 +0530
From: Jayesh Choudhary <j-choudhary@...com>
To: "Kumar, Udit" <u-kumar1@...com>, <nm@...com>, <vigneshr@...com>,
<devicetree@...r.kernel.org>
CC: <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
<conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <devarsht@...com>
Subject: Re: [PATCH v2 6/7] arm64: dts: ti: k3-j721s2-common-proc-board:
Enable DisplayPort-1
Hello Udit,
On 26/06/25 16:04, Kumar, Udit wrote:
>
> On 6/24/2025 1:56 PM, Jayesh Choudhary wrote:
>> Enable DSI display for J721S2 EVM.
>>
>> Add the endpoint nodes to describe connection from:
>> DSS => DSI Bridge => DSI to eDP bridge => DisplayPort-1
>>
>> Set status for all required nodes for DisplayPort-1 as 'okay'.
>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
>> ---
>> .../dts/ti/k3-j721s2-common-proc-board.dts | 89 +++++++++++++++++++
>> 1 file changed, 89 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> index 793d50344fad..efe857a50bb1 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> @@ -93,6 +93,29 @@ vdd_sd_dv: gpio-regulator-TLV71033 {
>> <3300000 0x1>;
>> };
>> + dp1_pwr_3v3: regulator-dp1-prw {
>> + compatible = "regulator-fixed";
>> + regulator-name = "dp1-pwr";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + gpio = <&exp4 1 GPIO_ACTIVE_HIGH>; /* P1 - DP1_PWR_SW_EN */
>> + enable-active-high;
>> + regulator-always-on;
>
> Please check once, if this regulator falls under regulator-always-on case,
>
> I can imagine a case, where DP1 is not used and still regulator is kept on
Yes it is not required.
I will remove this property from j721s2-common-proc-board and am68-sk
board dts.
Thanks,
Jayesh
>
>
>> + };
>> +
>> + dp1: connector-dp1 {
>> + compatible = "dp-connector";
[...]
Powered by blists - more mailing lists