linux-kernel - Re: kernel/trace/trace_fprobe.c:1264:12: warning: stack frame size (1032) exceeds limit (1024) in 'trace_fprobe_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250716145954.93465b106813127bad546ed0@kernel.org>
Date: Wed, 16 Jul 2025 14:59:54 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
 linux-kernel@...r.kernel.org, "Steven Rostedt (Google)"
 <rostedt@...dmis.org>
Subject: Re: kernel/trace/trace_fprobe.c:1264:12: warning: stack frame size
 (1032) exceeds limit (1024) in 'trace_fprobe_create_cb'

On Tue, 24 Jun 2025 04:18:46 +0800
kernel test robot <lkp@...el.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   86731a2a651e58953fc949573895f2fa6d456841
> commit: 57faaa04804ccbf16582f7fc7a6b986fd0c0e78c tracing: probe-events: Log error for exceeding the number of arguments
> date:   3 months ago
> config: s390-defconfig (https://download.01.org/0day-ci/archive/20250624/202506240416.nZIhDXoO-lkp@intel.com/config)
> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 875b36a8742437b95f623bab1e0332562c7b4b3f)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250624/202506240416.nZIhDXoO-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506240416.nZIhDXoO-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> kernel/trace/trace_fprobe.c:1264:12: warning: stack frame size (1032) exceeds limit (1024) in 'trace_fprobe_create_cb' [-Wframe-larger-than]
>     1264 | static int trace_fprobe_create_cb(int argc, const char *argv[])
>          |            ^
>    1 warning generated.

Hmm, maybe this includes the stack consumed by internal
inlined function (trace_fprobe_create_internal()). If so,
we can allocate some temporary buffer in it.

Thanks, 

> 
> 
> vim +/trace_fprobe_create_cb +1264 kernel/trace/trace_fprobe.c
> 
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1263) 
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17 @1264) static int trace_fprobe_create_cb(int argc, const char *argv[])
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1265) {
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1266) 	struct traceprobe_parse_context ctx = {
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1267) 		.flags = TPARG_FL_KERNEL | TPARG_FL_FPROBE,
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1268) 	};
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1269) 	int ret;
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1270) 
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1271) 	trace_probe_log_init("trace_fprobe", argc, argv);
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1272) 	ret = trace_fprobe_create_internal(argc, argv, &ctx);
> b1d1e90490b6714 Masami Hiramatsu (Google  2023-08-23  1273) 	traceprobe_finish_parse(&ctx);
> 334e5519c375701 Masami Hiramatsu (Google  2023-06-06  1274) 	trace_probe_log_clear();
> 334e5519c375701 Masami Hiramatsu (Google  2023-06-06  1275) 	return ret;
> 334e5519c375701 Masami Hiramatsu (Google  2023-06-06  1276) }
> 334e5519c375701 Masami Hiramatsu (Google  2023-06-06  1277) 
> 
> :::::: The code at line 1264 was first introduced by commit
> :::::: 8275637215bd3d447b31d37f9b8231a013adb042 tracing: Adopt __free() and guard() for trace_fprobe.c
> 
> :::::: TO: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> :::::: CC: Steven Rostedt (Google) <rostedt@...dmis.org>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>