linux-kernel - Re: [PATCH next] fs: tighten a sanity check in file_attr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250716-abdecken-backpulver-576b9e593f38@brauner>
Date: Wed, 16 Jul 2025 10:22:15 +0200
From: Christian Brauner <brauner@...nel.org>
To: Andrey Albershteyn <aalbersh@...hat.com>,
	Dan Carpenter <dan.carpenter@...aro.org>
Cc: Christian Brauner <brauner@...nel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Jan Kara <jack@...e.cz>,
	Arnd Bergmann <arnd@...db.de>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] fs: tighten a sanity check in file_attr_to_fileattr()

On Tue, 15 Jul 2025 18:03:17 -0500, Dan Carpenter wrote:
> The fattr->fa_xflags is a u64 that comes from the user.  This is a sanity
> check to ensure that the users are only setting allowed flags.  The
> problem is that it doesn't check the upper 32 bits.  It doesn't really
> affect anything but for more flexibility in the future, we want to enforce
> users zero out those bits.
> 
> 
> [...]

Applied to the vfs-6.17.fileattr branch of the vfs/vfs.git tree.
Patches in the vfs-6.17.fileattr branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.17.fileattr

[1/1] fs: tighten a sanity check in file_attr_to_fileattr()
      https://git.kernel.org/vfs/vfs/c/e85931d1cd69