linux-kernel - Re: [PATCH v2 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add qcom,subsys-restart property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250716-functional-loutish-peccary-dcb4c6@krzk-bin>
Date: Wed, 16 Jul 2025 10:33:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Anjelique Melendez <anjelique.melendez@....qualcomm.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, dmitry.baryshkov@....qualcomm.com, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add
 qcom,subsys-restart property

On Tue, Jul 15, 2025 at 05:40:03PM -0700, Anjelique Melendez wrote:
> Add new "qcom,subsys-restart" property to enable subsystem restart (SSR)
> notifications.
> 
> Signed-off-by: Anjelique Melendez <anjelique.melendez@....qualcomm.com>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml         | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 4c9e78f29523..90011096894e 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -49,6 +49,10 @@ properties:
>    '#size-cells':
>      const: 0
>  
> +  qcom,subsys-restart:
> +    description: If property is specified subsystem restart (SSR) notifications will be enabled.


Please wrap according to Linux coding style... if this stays, because
this all sounds like Linux notificatons, so an OS property.

The commit msg explains nothing - just repeats this. You need to
describe the hardware and the reasons behind this change - WHY you are
doing things - in terms of hardware.

Best regards,
Krzysztof