linux-kernel - Re: [PATCH 1/2] LoongArch: KVM: INTC: Remove local variable device1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H5qjr9GM6E-p43WBoCWNM8+Ag1=fCLw0+dP9_VPKjjp4A@mail.gmail.com>
Date: Wed, 16 Jul 2025 16:57:33 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Bibo Mao <maobibo@...ngson.cn>
Cc: Tianrui Zhao <zhaotianrui@...ngson.cn>, Xianglai Li <lixianglai@...ngson.cn>, kvm@...r.kernel.org, 
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] LoongArch: KVM: INTC: Remove local variable device1

Applied, thanks.


Huacai

On Mon, Jun 16, 2025 at 3:35 PM Bibo Mao <maobibo@...ngson.cn> wrote:
>
> Local variable device1 can be replaced with existing variable device,
> it makes code concise.
>
> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
> ---
>  arch/loongarch/kvm/intc/eiointc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/loongarch/kvm/intc/eiointc.c b/arch/loongarch/kvm/intc/eiointc.c
> index f39929d7bf8a..d9c4fe93405d 100644
> --- a/arch/loongarch/kvm/intc/eiointc.c
> +++ b/arch/loongarch/kvm/intc/eiointc.c
> @@ -956,7 +956,7 @@ static int kvm_eiointc_create(struct kvm_device *dev, u32 type)
>  {
>         int ret;
>         struct loongarch_eiointc *s;
> -       struct kvm_io_device *device, *device1;
> +       struct kvm_io_device *device;
>         struct kvm *kvm = dev->kvm;
>
>         /* eiointc has been created */
> @@ -984,10 +984,10 @@ static int kvm_eiointc_create(struct kvm_device *dev, u32 type)
>                 return ret;
>         }
>
> -       device1 = &s->device_vext;
> -       kvm_iodevice_init(device1, &kvm_eiointc_virt_ops);
> +       device = &s->device_vext;
> +       kvm_iodevice_init(device, &kvm_eiointc_virt_ops);
>         ret = kvm_io_bus_register_dev(kvm, KVM_IOCSR_BUS,
> -                       EIOINTC_VIRT_BASE, EIOINTC_VIRT_SIZE, device1);
> +                       EIOINTC_VIRT_BASE, EIOINTC_VIRT_SIZE, device);
>         if (ret < 0) {
>                 kvm_io_bus_unregister_dev(kvm, KVM_IOCSR_BUS, &s->device);
>                 kfree(s);
> --
> 2.39.3
>