[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJM55Z_77aygReSPJyZMtfZWk_UPYTzYLH5E5uEw6K=GSu0LNQ@mail.gmail.com>
Date: Wed, 16 Jul 2025 02:17:34 -0700
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: E Shattow <e@...eshell.de>, Emil Renner Berthing <kernel@...il.dk>, Conor Dooley <conor@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>
Cc: linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-milkv-mars sort properties
E Shattow wrote:
> Improve style with node property order sort of common properties before
> vendor prefixes
>
> Signed-off-by: E Shattow <e@...eshell.de>
Thanks!
Acked-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
> ---
> arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> index 3bd62ab78523..fdaf6b4557da 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> +++ b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> @@ -12,9 +12,9 @@ / {
> };
>
> &gmac0 {
> - starfive,tx-use-rgmii-clk;
> assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>;
> assigned-clock-parents = <&aoncrg JH7110_AONCLK_GMAC0_RMII_RTX>;
> + starfive,tx-use-rgmii-clk;
> status = "okay";
> };
>
> @@ -31,14 +31,14 @@ &pcie1 {
> };
>
> &phy0 {
> - motorcomm,tx-clk-adj-enabled;
> + rx-internal-delay-ps = <1500>;
> + tx-internal-delay-ps = <1500>;
> + motorcomm,rx-clk-drv-microamp = <3970>;
> + motorcomm,rx-data-drv-microamp = <2910>;
> motorcomm,tx-clk-10-inverted;
> motorcomm,tx-clk-100-inverted;
> motorcomm,tx-clk-1000-inverted;
> - motorcomm,rx-clk-drv-microamp = <3970>;
> - motorcomm,rx-data-drv-microamp = <2910>;
> - rx-internal-delay-ps = <1500>;
> - tx-internal-delay-ps = <1500>;
> + motorcomm,tx-clk-adj-enabled;
> };
>
> &pwm {
>
> base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
> --
> 2.50.0
>
Powered by blists - more mailing lists