linux-kernel - Re: [PATCH v2 2/3] bus: mhi: host: keep bhie buffer through suspend cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025071651-rake-rake-7a13@gregkh>
Date: Wed, 16 Jul 2025 11:35:14 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
	Jeff Hugo <jeff.hugo@....qualcomm.com>,
	Youssef Samir <quic_yabdulra@...cinc.com>,
	Matthew Leung <quic_mattleun@...cinc.com>,
	Alexander Wilhelm <alexander.wilhelm@...termo.com>,
	Kunwu Chan <chentao@...inos.cn>,
	Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>,
	Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
	Yan Zhen <yanzhen@...o.com>, Sujeev Dias <sdias@...eaurora.org>,
	Siddartha Mohanadoss <smohanad@...eaurora.org>, mhi@...ts.linux.dev,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...labora.com, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/3] bus: mhi: host: keep bhie buffer through suspend
 cycle

On Tue, Jul 15, 2025 at 06:25:08PM +0500, Muhammad Usama Anjum wrote:
> When there is memory pressure, at resume time dma_alloc_coherent()
> returns error which in turn fails the loading of the firmware and hence
> the driver crashes.
> 
> Fix it by allocating only once and then reuse the same allocated memory.
> As we'll allocate this memory only once, this memory will stays
> allocated.

Again, no, do not waste memory like this.  If all drivers/devices did
this that would be horrible.

greg k-h