| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAFEp6-0hDqgYsjOy2mCC6ssK2LkMM0z7L_szS+M_wSMeMe3pMg@mail.gmail.com>
Date: Wed, 16 Jul 2025 11:36:14 +0200
From: Loic Poulain <loic.poulain@....qualcomm.com>
To: "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Robert Foss <rfoss@...nel.org>,
Todor Tomov <todor.too@...il.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org
Subject: Re: [PATCH v7 04/15] media: qcom: camss: Add support for PHY API devices
Hi Bryan,
On Fri, Jul 11, 2025 at 2:59 PM Bryan O'Donoghue
<bryan.odonoghue@...aro.org> wrote:
>
> Add the ability to use a PHY pointer which interacts with the standard PHY
> API.
>
> In the first instance the code will try to use the new PHY interface. If no
> PHYs are present in the DT then the legacy method will be attempted.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
> drivers/media/platform/qcom/camss/Kconfig | 1 +
> drivers/media/platform/qcom/camss/camss-csiphy.c | 157 ++++++++++++++++++++---
> drivers/media/platform/qcom/camss/camss-csiphy.h | 7 +
> drivers/media/platform/qcom/camss/camss.c | 56 ++++++--
> 4 files changed, 194 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
> index 4eda48cb1adf049a7fb6cb59b9da3c0870fe57f4..1edc5e5a1829e033812bbadfa0de00625fd0c93a 100644
> --- a/drivers/media/platform/qcom/camss/Kconfig
> +++ b/drivers/media/platform/qcom/camss/Kconfig
> @@ -7,3 +7,4 @@ config VIDEO_QCOM_CAMSS
> select VIDEO_V4L2_SUBDEV_API
> select VIDEOBUF2_DMA_SG
> select V4L2_FWNODE
> + select PHY_QCOM_MIPI_CSI2
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c
> index 2de97f58f9ae4f91e8bba39dcadf92bea8cf6f73..185a51aa73d102b9555e550d8041c25c8adf9af8 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c
[...]
> +int msm_csiphy_subdev_init_legacy(struct camss *camss,
> + struct csiphy_device *csiphy,
> + const struct camss_subdev_resources *res, u8 id);
> +
> int msm_csiphy_subdev_init(struct camss *camss,
> struct csiphy_device *csiphy,
> const struct camss_subdev_resources *res, u8 id);
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index c8103f8b754a29a63e32bb7bc213bfe14b4e0748..1817fa7f922b3b30168655bffbcd629feeec167a 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -3092,18 +3092,40 @@ static int camss_init_subdevices(struct camss *camss)
> {
> struct platform_device *pdev = to_platform_device(camss->dev);
> const struct camss_resources *res = camss->res;
> + struct device_node *phy_np;
> unsigned int i;
> int ret;
>
> for (i = 0; i < camss->res->csiphy_num; i++) {
> - ret = msm_csiphy_subdev_init(camss, &camss->csiphy[i],
> - &res->csiphy_res[i],
> - res->csiphy_res[i].csiphy.id);
> - if (ret < 0) {
> - dev_err(camss->dev,
> - "Failed to init csiphy%d sub-device: %d\n",
> - i, ret);
> - return ret;
> + phy_np = of_parse_phandle(pdev->dev.of_node, "phys", i);
> + if (phy_np && of_device_is_available(phy_np)) {
> + ret = msm_csiphy_subdev_init(camss, &camss->csiphy[i],
> + &res->csiphy_res[i],
> + res->csiphy_res[i].csiphy.id);
> + if (ret < 0) {
> + dev_err(camss->dev,
> + "Failed to init csiphy%d sub-device: %d\n",
> + i, ret);
> + return ret;
> + }
> + }
> + }
> +
> + if (!phy_np) {
> + if (!res->legacy_phy)
> + return -ENODEV;
> +
> + for (i = 0; i < camss->res->csiphy_num; i++) {
> + ret = msm_csiphy_subdev_init_legacy(camss, &camss->csiphy[i],
> + &res->csiphy_res[i],
> + res->csiphy_res[i].csiphy.id);
> + if (ret < 0) {
> + dev_err(camss->dev,
> + "Failed to init csiphy%d sub-device: %d\n",
> + i, ret);
> + return ret;
> + }
> + camss->csiphy[i].phy = ERR_PTR(-ENODEV);
> }
So what happens if we have `phy_np` and `!of_device_is_available`, we
just continue without any phy initialized?
> }
>
> @@ -3181,6 +3203,9 @@ static int camss_link_entities(struct camss *camss)
>
> for (i = 0; i < camss->res->csiphy_num; i++) {
> for (j = 0; j < camss->res->csid_num; j++) {
> + if (!camss->csiphy[i].phy)
> + continue;
> +
> ret = media_create_pad_link(&camss->csiphy[i].subdev.entity,
> MSM_CSIPHY_PAD_SRC,
> &camss->csid[j].subdev.entity,
> @@ -3290,6 +3315,9 @@ static int camss_register_entities(struct camss *camss)
> int ret;
>
> for (i = 0; i < camss->res->csiphy_num; i++) {
> + if (!camss->csiphy[i].phy)
> + continue;
> +
> ret = msm_csiphy_register_entity(&camss->csiphy[i],
> &camss->v4l2_dev);
> if (ret < 0) {
> @@ -3345,8 +3373,10 @@ static int camss_register_entities(struct camss *camss)
>
> i = camss->res->csiphy_num;
> err_reg_csiphy:
> - for (i--; i >= 0; i--)
> - msm_csiphy_unregister_entity(&camss->csiphy[i]);
> + for (i--; i >= 0; i--) {
> + if (camss->csiphy[i].phy)
> + msm_csiphy_unregister_entity(&camss->csiphy[i]);
> + }
>
> return ret;
> }
> @@ -3361,8 +3391,10 @@ static void camss_unregister_entities(struct camss *camss)
> {
> unsigned int i;
>
> - for (i = 0; i < camss->res->csiphy_num; i++)
> - msm_csiphy_unregister_entity(&camss->csiphy[i]);
> + for (i = 0; i < camss->res->csiphy_num; i++) {
> + if (camss->csiphy[i].phy)
> + msm_csiphy_unregister_entity(&camss->csiphy[i]);
> + }
>
> for (i = 0; i < camss->res->csid_num; i++)
> msm_csid_unregister_entity(&camss->csid[i]);
>
> --
> 2.49.0
>
>
Powered by blists - more mailing lists