linux-kernel - Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85b79e18-8c67-47d9-8520-0dfd31a5a6fd@redhat.com>
Date: Wed, 16 Jul 2025 11:43:42 +0200
From: David Hildenbrand <david@...hat.com>
To: Dishank Jogi <dishank.jogi@...ol.com>, Kees Cook <kees@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Vlastimil Babka
 <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Juri Lelli <juri.lelli@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
 Christian Brauner <brauner@...nel.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] "fork: reorder function qualifiers for
 copy_clone_args_from_user"

On 16.07.25 11:35, Dishank Jogi wrote:

"" in patch subject is weird

> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
> 
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.

Simplify to "No functional change intended." All the other stuff can be 
dropped from this sentence IMHO -- I'd even drop the whole sentence.

> 
> Signed-off-by: Dishank Jogi <dishank.jogi@...ol.com>
> ---
>   kernel/fork.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 1ee8eb11f38b..574ff0d983db 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
>   }
>   #endif
>   
> -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
>   					      struct clone_args __user *uargs,
>   					      size_t usize)
>   {

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb