linux-kernel - Re: [PATCH v1 1/1] serial: 8250_ce4100: Fix CONFIG_SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3240539-04b1-4141-95b8-fde193afa25d@kernel.org>
Date: Wed, 16 Jul 2025 12:14:23 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Cc: Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_ce4100: Fix CONFIG_SERIAL_8250=n
 build

On 16. 07. 25, 11:44, Andy Shevchenko wrote:
> On i386, when
> 
>    CONFIG_X86_INTEL_CE=y
>    # CONFIG_SERIAL_8250 is not set
> 
> will try to compile the driver and use the stub simultaneously.
> This breaks the build. Fix it by making sure that the driver
> compiles only when CONFIG_SERIAL_8250 is also enabled.
> 
> Fixes: acc902de05b2 ("serial: 8250: Move CE4100 quirks to a module under 8250 driver")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Closes: https://lore.kernel.org/r/cdf4ee46-7bf8-4379-9245-fed9db72e7e8@infradead.org
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/tty/serial/8250/Makefile | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/Makefile b/drivers/tty/serial/8250/Makefile
> index e61dc3f4ca50..1d6633bbcd70 100644
> --- a/drivers/tty/serial/8250/Makefile
> +++ b/drivers/tty/serial/8250/Makefile
> @@ -24,7 +24,9 @@ obj-$(CONFIG_SERIAL_8250_ASPEED_VUART)	+= 8250_aspeed_vuart.o
>   obj-$(CONFIG_SERIAL_8250_BCM2835AUX)	+= 8250_bcm2835aux.o
>   obj-$(CONFIG_SERIAL_8250_BCM7271)	+= 8250_bcm7271.o
>   obj-$(CONFIG_SERIAL_8250_BOCA)		+= 8250_boca.o
> +ifneq ($(CONFIG_SERIAL_8250),)

Why not ifdef CONFIG_SERIAL_8250 then?

Also, what happens if 8250=m and X86_INTEL_CE=y?

>   obj-$(CONFIG_X86_INTEL_CE)		+= 8250_ce4100.o
> +endif
>   obj-$(CONFIG_SERIAL_8250_DFL)		+= 8250_dfl.o
>   obj-$(CONFIG_SERIAL_8250_DW)		+= 8250_dw.o
>   obj-$(CONFIG_SERIAL_8250_EM)		+= 8250_em.o


-- 
js
suse labs