linux-kernel - Re: [PATCH net v2] et131x: Add missing check after DMA map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ba42e9ae61e8274bf5d677f8d53c84f6841ccd8.camel@gmail.com>
Date: Wed, 16 Jul 2025 12:19:50 +0100
From: mark.einon@...il.com
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,  Ingo Molnar
 <mingo@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 netdev@...r.kernel.org, 	linux-kernel@...r.kernel.org, Simon Horman
 <horms@...nel.org>
Subject: Re: [PATCH net v2] et131x: Add missing check after DMA map

On Wed, 2025-07-16 at 11:47 +0200, Thomas Fourier wrote:
> The DMA map functions can fail and should be tested for errors.
> If the mapping fails, unmap and return an error.
> 
> Fixes: 38df6492eb51 ("et131x: Add PCIe gigabit ethernet driver et131x
> to drivers/net")
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>
> ---
> v1 -> v2:
>   - Fix subject
>   - Fix double decrement of frag
>   - Make comment more explicit about why there are two loops

Thanks for the updates Thomas, LGTM (also CC'd Simon who provided the
initial comments).

Acked-by: Mark Einon <mark.einon@...il.com>