linux-kernel - Re: [PATCH v3 00/24] pmdomain: Add generic ->sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DBDI4X0LDTPZ.16PODOZINXKEP@kernel.org>
Date: Wed, 16 Jul 2025 15:08:57 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Ulf Hansson" <ulf.hansson@...aro.org>
Cc: "Saravana Kannan" <saravanak@...gle.com>, "Stephen Boyd"
 <sboyd@...nel.org>, <linux-pm@...r.kernel.org>, "Rafael J . Wysocki"
 <rafael@...nel.org>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Michael Grzeschik" <m.grzeschik@...gutronix.de>, "Bjorn Andersson"
 <andersson@...nel.org>, "Abel Vesa" <abel.vesa@...aro.org>, "Peng Fan"
 <peng.fan@....nxp.com>, "Tomi Valkeinen" <tomi.valkeinen@...asonboard.com>,
 "Johan Hovold" <johan@...nel.org>, "Maulik Shah"
 <maulik.shah@....qualcomm.com>, "Michal Simek" <michal.simek@....com>,
 "Konrad Dybcio" <konradybcio@...nel.org>, "Thierry Reding"
 <thierry.reding@...il.com>, "Jonathan Hunter" <jonathanh@...dia.com>,
 "Hiago De Franco" <hiago.franco@...adex.com>, "Geert Uytterhoeven"
 <geert@...ux-m68k.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 00/24] pmdomain: Add generic ->sync_state() support
 to genpd

On Wed Jul 16, 2025 at 2:46 PM CEST, Ulf Hansson wrote:
> On Tue, 15 Jul 2025 at 10:50, Danilo Krummrich <dakr@...nel.org> wrote:
>>
>> Hi Ulf,
>>
>> On Wed Jul 9, 2025 at 1:30 PM CEST, Ulf Hansson wrote:
>> > I decided it was time to give this a try, so I have queued this up for
>> > v6.17 via the next branch at my pmdomain tree.
>> >
>> > If you encounter any issues, please let me know so I can help to fix them.
>>
>> Can you please address my concern in patch 17 ("driver core: Export
>> get_dev_from_fwnode()")?
>>
>> Since this has been applied already, a subsequent patch would be perfectly fine.
>
> Hi Danilo,
>
> As Greg and Saravana were happy, I didn't want to hold back the whole
> series only because of a minor comment on some missing documentation.

Fair enough -- yet, a brief reply asking if it can be done as a follow-up would
have been appreciated.

I don't think it's that minor. The race may be unlikely to happen, but if it
happens because someone isn't careful with this (now exported) API - and I'm
absolutely sure it's only gonna be a matter of time until that happens -, it'll
be painful. :(

> But, yes, let me look into it. It may take a while though, as vacation
> is getting closer. If you want to send a patch yourself, please, feel
> free to do it.

Ok, let me see if I can get to it.

> Note that, while at it, we should probably also add some documentation
> of device_set_node() (next to get_dev_from_fwnode()) as it also lacks
> it.

Agreed!

Have a nice vacation!

- Danilo