linux-kernel - Re: [RFC 2/6] greybus: cpc: add core logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025071645-awkward-spotted-9d25@gregkh>
Date: Wed, 16 Jul 2025 15:21:08 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Damien Riégel <damien.riegel@...abs.com>
Cc: greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
	linux-devel@...abs.com, Alex Elder <elder@...nel.org>,
	Johan Hovold <johan@...nel.org>
Subject: Re: [RFC 2/6] greybus: cpc: add core logic

On Fri, Jul 04, 2025 at 08:40:32PM -0400, Damien Riégel wrote:
> This step adds the basic infrastructure in order to use CPC as backend
> in Greybus. The goal of CPC is to add reliablity, by implementing error
> detection and retransmission for links that don't have that capability
> by default.
> 
> When Greybus establishes the connection between two CPorts, CPC will
> create an endpoint for this connection. Greybus messages will then be
> encapsulated in CPC frames, which basically are a custom header +
> Greybus header + Greybus payload.
> 
> As this is still evolving and not the main point of the RFC, the whole
> core is squashed in one big commit, but it will definitely be split into
> more digestible commits as we refine it.
> 
> Signed-off-by: Damien Riégel <damien.riegel@...abs.com>
> ---
>  MAINTAINERS                    |   6 +
>  drivers/greybus/Kconfig        |   2 +
>  drivers/greybus/Makefile       |   2 +
>  drivers/greybus/cpc/Kconfig    |  12 ++
>  drivers/greybus/cpc/Makefile   |   6 +
>  drivers/greybus/cpc/cpc.h      | 135 ++++++++++++++++
>  drivers/greybus/cpc/endpoint.c | 158 +++++++++++++++++++
>  drivers/greybus/cpc/header.c   | 212 +++++++++++++++++++++++++
>  drivers/greybus/cpc/header.h   |  81 ++++++++++
>  drivers/greybus/cpc/host.c     | 113 ++++++++++++++
>  drivers/greybus/cpc/protocol.c | 274 +++++++++++++++++++++++++++++++++
>  11 files changed, 1001 insertions(+)

I like the idea, but you are going to have to break this up into smaller
pieces in order to get us to be able to review it well, sorry.

thanks

greg k-h