linux-kernel - Re: [RFC 6/6] greybus: add class driver for Silabs Bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025071617-plant-daytime-582a@gregkh>
Date: Wed, 16 Jul 2025 15:23:45 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Damien Riégel <damien.riegel@...abs.com>
Cc: greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
	linux-devel@...abs.com, Alex Elder <elder@...nel.org>,
	Johan Hovold <johan@...nel.org>
Subject: Re: [RFC 6/6] greybus: add class driver for Silabs Bluetooth

On Fri, Jul 04, 2025 at 08:40:36PM -0400, Damien Riégel wrote:
> +#include <linux/greybus.h>
> +#include <linux/skbuff.h>
> +#include <net/bluetooth/bluetooth.h>
> +#include <net/bluetooth/hci_core.h>
> +
> +#define GREYBUS_VENDOR_SILABS	0xBEEF
> +#define GREYBUS_PRODUCT_EFX	0xCAFE

Nice vendor ids :)

We really should make a file for all of the current ones, to keep track
of them.  At the least, the vendor ids should be made unique.

Overall this looks very good, a clean and small driver.  Would you have
other ones for this type of transport layer?

thanks,

greg k-h