linux-kernel - [PATCH] fs/proc: Use inode_get_dev() for device numbers in procmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250716142732.3385310-1-wegao@suse.com>
Date: Wed, 16 Jul 2025 10:27:32 -0400
From: Wei Gao <wegao@...e.com>
To: Andrew Morton <akpm@...ux-foundation.org>,
	David Hildenbrand <david@...hat.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Jason A. Donenfeld" <Jason@...c4.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Penglei Jiang <superman.xpt@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Joey Gouly <joey.gouly@....com>,
	Brahmajit Das <brahmajit.xyz@...il.com>,
	Andrei Vagin <avagin@...il.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Andrii Nakryiko <andrii@...nel.org>,
	Ryan Roberts <ryan.roberts@....com>,
	linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	Wei Gao <wegao@...e.com>
Subject: [PATCH] fs/proc: Use inode_get_dev() for device numbers in procmap_query

This ensures consistency and proper abstraction when accessing device
information associated with an inode.

Signed-off-by: Wei Gao <wegao@...e.com>
---
 fs/proc/task_mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 751479eb128f..b113a274f814 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -518,8 +518,8 @@ static int do_procmap_query(struct proc_maps_private *priv, void __user *uarg)
 		const struct inode *inode = file_user_inode(vma->vm_file);
 
 		karg.vma_offset = ((__u64)vma->vm_pgoff) << PAGE_SHIFT;
-		karg.dev_major = MAJOR(inode->i_sb->s_dev);
-		karg.dev_minor = MINOR(inode->i_sb->s_dev);
+		karg.dev_major = MAJOR(inode_get_dev(inode));
+		karg.dev_minor = MINOR(inode_get_dev(inode));
 		karg.inode = inode->i_ino;
 	} else {
 		karg.vma_offset = 0;
-- 
2.49.0