linux-kernel - Re: [PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025071759-john-puzzling-b3af@gregkh>
Date: Thu, 17 Jul 2025 16:34:13 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Romain Gantois <romain.gantois@...tlin.com>,
	Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter
 callbacks

On Thu, Jul 17, 2025 at 03:32:07PM +0200, Bartosz Golaszewski wrote:
> On Thu, Jul 17, 2025 at 3:04 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > struct gpio_chip now has callbacks for setting line values that return
> > an integer, allowing to indicate failures. Convert the driver to using
> > them.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > ---
> 
> Greg: this patch comes in late into the cycle but the driver in
> question got merged for v6.16-rc1 despite the set() callback in struct
> gpio_chip being already deprecated and it went below my radar. This is
> one of the few remaining conversions and if we get it queued for
> v6.17, we'll be able to complete it next release and drop legacy
> callbacks. I know you're busy so if you could Ack it (and I hope I can
> get a review from Romain and Linus), I'm more than happy to take it
> through the GPIO tree to speed up the process.

No worries, please take it through your tree, now acked.

greg k-h