linux-kernel - [PATCH] mfd: adp5585: Drop useless return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250717-adp5585-drop-ret-v1-1-2ae65bd780aa@analog.com>
Date: Thu, 17 Jul 2025 15:51:34 +0100
From: Nuno Sá via B4 Relay <devnull+nuno.sa.analog.com@...nel.org>
To: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
 Lee Jones <lee@...nel.org>, Dan Carpenter <dan.carpenter@...aro.org>
Subject: [PATCH] mfd: adp5585: Drop useless return statement

From: Nuno Sá <nuno.sa@...log.com>

In adp5585_reset_ev_parse(), when parsing the
adi,reset-pulse-width-us property, we were returning in case it was
found and valid. No point in doing that as we'll be returning anyways
after the exiting the property scope. And it could actually lead to bugs
if new properties happen to added after this one.

Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Closes: https://lore.kernel.org/linux-gpio/c85604d9e077511b8aa6ee0786579594cc0103d4.camel@gmail.com/T/#ma25557bd06ccd2531dc9c85ba6be74af781b81aa
Signed-off-by: Nuno Sá <nuno.sa@...log.com>
---
 drivers/mfd/adp5585.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/adp5585.c b/drivers/mfd/adp5585.c
index 58f7cebe2ea4f2c68f64370449f5fbce8a2f14ed..46b3ce3d7bae8981824a957f6b4ee471d803c981 100644
--- a/drivers/mfd/adp5585.c
+++ b/drivers/mfd/adp5585.c
@@ -432,7 +432,6 @@ static int adp5585_reset_ev_parse(struct adp5585_dev *adp5585)
 					     "Invalid value(%u) for adi,reset-pulse-width-us\n",
 					     prop_val);
 		}
-		return ret;
 	}
 
 	return 0;

---
base-commit: 8f3ef4da96dd3f3e12f6313cbe8cd16a39e9abae
change-id: 20250717-adp5585-drop-ret-6b110977a0ad
--

Thanks!
- Nuno Sá