linux-kernel - [PATCH 0/9] USB/IP VHCI suspend fix and driver cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250717-vhci-hcd-suspend-fix-v1-0-2b000cd05952@collabora.com>
Date: Thu, 17 Jul 2025 18:54:49 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Valentina Manea <valentina.manea.m@...il.com>, 
 Shuah Khan <shuah@...nel.org>, Hongren Zheng <i@...ithal.me>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 "Brian G. Merrell" <bgmerrell@...ell.com>
Cc: kernel@...labora.com, Greg Kroah-Hartman <gregkh@...e.de>, 
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 0/9] USB/IP VHCI suspend fix and driver cleanup

The USB/IP Virtual Host Controller (VHCI) platform driver is expected to
prevent entering system suspend when at least one remote device is
attached to the virtual USB root hub.

However, in some cases, the detection logic for active USB/IP
connections doesn't seem to work reliably, e.g. when all devices
attached to the virtual hub have been already suspended.  This will
normally lead to a broken suspend state, with unrecoverable resume.

The first patch of the series provides a workaround to ensure the
attached devices do not enter suspend.

Additionally, during the investigation I noticed and fixed a bunch of
coding style issues, hence the subsequent patches contain all the
changes needed to make checkpatch happy for the entire driver.

WARNING:

Please note commit aa7a9275ab81 ("PM: sleep: Suspend async parents after
suspending children") from v6.16-rc1 introduced a regression which
breaks the suspend cancellation and hangs the system.

A fix [1] has been already provided, which is expected to land in
v6.16-rc7.  The patch is currently available in next-20250717, which
this series is also based on, as commit ebd6884167ea ("PM: sleep: Update
power.completion for all devices on errors").

[1] https://lore.kernel.org/all/6191258.lOV4Wx5bFT@rjwysocki.net/

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
---
Cristian Ciocaltea (9):
      usb: vhci-hcd: Prevent suspending virtually attached devices
      usb: vhci-hcd: Fix space, brace, alignment and line length issues
      usb: vhci-hcd: Simplify NULL comparison
      usb: vhci-hcd: Simplify kzalloc usage
      usb: vhci-hcd: Do not split quoted strings
      usb: vhci-hcd: Fix block comments
      usb: vhci-hcd: Use the paranthesized form of sizeof
      usb: vhci-hcd: Consistently use __func__
      usb: vhci-hcd: Remove ftrace-like logging

 drivers/usb/usbip/vhci_hcd.c | 184 +++++++++++++++++++++----------------------
 1 file changed, 89 insertions(+), 95 deletions(-)
---
base-commit: 024e09e444bd2b06aee9d1f3fe7b313c7a2df1bb
change-id: 20250714-vhci-hcd-suspend-fix-7db5c25c509d