linux-kernel - Re: [PATCH net-next v6] tcp: trace retransmit failures in tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250717101241665SpBGi_zaErkDSM2Rgmx3o@zte.com.cn>
Date: Thu, 17 Jul 2025 10:12:41 +0800 (CST)
From: <fan.yu9@....com.cn>
To: <kuniyu@...gle.com>
Cc: <kuba@...nel.org>, <edumazet@...gle.com>, <ncardwell@...gle.com>,
        <davem@...emloft.net>, <dsahern@...nel.org>, <pabeni@...hat.com>,
        <horms@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>,
        <yang.yang29@....com.cn>, <xu.xin16@....com.cn>,
        <tu.qiang35@....com.cn>, <jiang.kun2@....com.cn>,
        <qiu.yutan@....com.cn>, <wang.yaxin@....com.cn>,
        <he.peilin@....com.cn>
Subject: Re: [PATCH net-next v6] tcp: trace retransmit failures in tcp_retransmit_skb

> > print fmt: "skbaddr=%p skaddr=%p family=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s err=%d"
> >
> > Suggested-by: KuniyukiIwashima <kuniyu@...gle.com>
> 
> I don't deserve this tag.  (Also, a space between first/last name is missing.)
> 
> Suggested-by can be used when the core idea is provided by someone,
> but not when someone just reviews the patch and points out something
> wrong.
> 
> But code-wise, the change looks good to me.
> 
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>
Hi Kuniyuki,

Thank you for your thorough review and guidance - it's greatly appreciated.
I'll submit v7 with corrected tags :).
<div class="zcontentRow"><p>&gt; &gt; print fmt: "skbaddr=%p skaddr=%p family=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s err=%d"</p><p>&gt; &gt;</p><p>&gt; &gt; Suggested-by: KuniyukiIwashima &lt;kuniyu@...gle.com&gt;</p><p>&gt;&nbsp;</p><p>&gt; I don't deserve this tag.&nbsp; (Also, a space between first/last name is missing.)</p><p>&gt;&nbsp;</p><p>&gt; Suggested-by can be used when the core idea is provided by someone,</p><p>&gt; but not when someone just reviews the patch and points out something</p><p>&gt; wrong.</p><p>&gt;&nbsp;</p><p>&gt; But code-wise, the change looks good to me.</p><p>&gt;&nbsp;</p><p>&gt; Reviewed-by: Kuniyuki Iwashima &lt;kuniyu@...gle.com&gt;</p><p>Hi Kuniyuki,</p><p><br></p><p>Thank you for your thorough review and guidance - it's greatly appreciated.</p><p>I'll submit v7 with corrected tags :).<br></p></div>