linux-kernel - Re: [PATCH 2/9] usb: vhci-hcd: Fix space, brace, alignment and line length issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025071706-overarch-flaky-035b@gregkh>
Date: Thu, 17 Jul 2025 18:18:19 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
Cc: Valentina Manea <valentina.manea.m@...il.com>,
	Shuah Khan <shuah@...nel.org>, Hongren Zheng <i@...ithal.me>,
	"Brian G. Merrell" <bgmerrell@...ell.com>, kernel@...labora.com,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] usb: vhci-hcd: Fix space, brace, alignment and line
 length issues

On Thu, Jul 17, 2025 at 06:54:51PM +0300, Cristian Ciocaltea wrote:
> Perform a first round of coding style cleanup:
> 
> * Add new lines after several statement blocks
> * Avoid line wrapping when 100-column width is not exceeded and it helps
>   improve code readability
> * Ensure lines do not end with '('
> * Drop superfluous spaces or empty lines
> * Add spaces where necessary, e.g. around operators
> * Add braces for single if-statements when at least one branch of the
>   conditional requires them
> 
> This helps getting rid of the following checkpatch complaints:
> 
>   CHECK: Lines should not end with a '('
>   CHECK: braces {} should be used on all arms of this statement
>   CHECK: Unbalanced braces around else statement
>   CHECK: Blank lines aren't necessary before a close brace '}'
>   CHECK: Unnecessary parentheses around
>   CHECK: Alignment should match open parenthesis
>   CHECK: No space is necessary after a cast
>   CHECK: spaces preferred around that '-' (ctx:VxV)
>   CHECK: spaces preferred around that '+' (ctx:VxV)
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>

Coding style cleanups need to be "one patch per logical change", not
"fix them all in one patch!" type of thing.

Sorry, but can you break this out better?

thanks,

greg k-h