linux-kernel - Re: [PATCH] riscv: dts: starfive: jh7110-milkv-mars sort properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250717-recapture-frostbite-80d22fa325bf@spud>
Date: Thu, 17 Jul 2025 18:24:00 +0100
From: Conor Dooley <conor@...nel.org>
To: E Shattow <e@...eshell.de>
Cc: Emil Renner Berthing <emil.renner.berthing@...onical.com>,
	Emil Renner Berthing <kernel@...il.dk>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-milkv-mars sort properties

On Thu, Jul 17, 2025 at 12:06:57AM -0700, E Shattow wrote:
> 
> 
> On 7/16/25 08:28, Conor Dooley wrote:
> > On Wed, Jul 16, 2025 at 02:17:34AM -0700, Emil Renner Berthing wrote:
> >> E Shattow wrote:
> >>> Improve style with node property order sort of common properties before
> >>> vendor prefixes
> >>>
> >>> Signed-off-by: E Shattow <e@...eshell.de>
> >>
> >> Thanks!
> >>
> >> Acked-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
> > 
> > I'm going to pick this up, but it may be very late for 6.17.
> 
> Yes. The other questionable sort style in this dts I was looking at are
> whether we want "compatible" before "model" in the root '/' node?  And

I think usually model comes first, yeah. Whether that's worth doing
something about, I'll leave up to you.

> then why we have this common pattern of 'pinmux' (or pinctrl*)
> prioritized firstly in the natural sort order, also pinctrl-names before
> pinctrl-N is a common pattern that seems an arbitrary reversal of
> natural sort order?

Usually "foo" is followed by "foo-names", but pinctrl does appear to be
a bit different since everything has a -something suffix. Skimming, it
looks like there are actually more instances where pinctrl-names appears
before pinctrl-N.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)