[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <438f96a2-10dc-4665-b5de-bbd8b190a09c@infradead.org>
Date: Wed, 16 Jul 2025 19:25:16 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Johannes Thumshirn <Johannes.Thumshirn@....com>,
Stephen Rothwell <sfr@...b.auug.org.au>, Jens Axboe <axboe@...nel.dk>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the block tree
On 7/16/25 3:58 AM, Johannes Thumshirn wrote:
> On 16.07.25 12:37, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> include/trace/events/block.h:416: warning: Function parameter or struct member 'rq' not described in 'trace_blk_zone_append_update_request_bio'
>> include/trace/events/block.h:416: warning: expecting prototype for trace_block_zone_update_request_bio(). Prototype was for trace_blk_zone_append_update_request_bio() instead
>>
>> Introduced by commit
>>
>> 4cc21a00762b ("block: add tracepoint for blk_zone_update_request_bio")
>>
>
> Hi Stephen,
>
> Does this fix it for you:
>
> diff --git a/include/trace/events/block.h b/include/trace/events/block.h
> index 3e582d5e3a57..6aa79e2d799c 100644
> --- a/include/trace/events/block.h
> +++ b/include/trace/events/block.h
> @@ -405,8 +405,8 @@ DEFINE_EVENT(block_bio, block_getrq,
> );
>
> /**
> - * block_zone_update_request_bio - update the bio sector after a zone append
> - * @bio: the completed block IO operation
> + * blk_zone_append_update_request_bio - update bio sector after zone append
> + * @rq: the completed request that sets the bio sector
> *
> * Update the bio's bi_sector after a zone append command has been completed.
> */
>
>
> I'll submit a proper patch ASAP.
LGTM. Thanks.
Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>
--
~Randy
Powered by blists - more mailing lists