linux-kernel - Re: [PATCH] power: snapshot: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i3XNyyK+4ZnGOj54LiCvnd_Zz+xVr+cKpWoJRLETBO6w@mail.gmail.com>
Date: Thu, 17 Jul 2025 20:32:25 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Darshan Rathod <darshanrathod475@...il.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Pavel Machek <pavel@...nel.org>, Len Brown <len.brown@...el.com>, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: snapshot: Fix coding style issues

On Wed, Jul 16, 2025 at 2:42 PM Darshan Rathod
<darshanrathod475@...il.com> wrote:
>
> Clean up various coding style violations in snapshot.c identified by
> checkpatch.pl.
>
> - Add a space after control flow keywords (for, if).
> - Correct indentation from spaces to tabs for a variable declaration.
>
> These changes have no functional impact and improve compliance with the
> Linux Kernel Coding Style.
>
> Signed-off-by: Darshan Rathod <darshanrathod475@...il.com>
> ---
>  kernel/power/snapshot.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 2af36cfe35cd..501df0676a61 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -1536,7 +1536,7 @@ static unsigned long copy_data_pages(struct memory_bitmap *copy_bm,
>         memory_bm_position_reset(orig_bm);
>         memory_bm_position_reset(copy_bm);
>         copy_pfn = memory_bm_next_pfn(copy_bm);
> -       for(;;) {
> +       for (;;) {
>                 pfn = memory_bm_next_pfn(orig_bm);
>                 if (unlikely(pfn == BM_END_OF_MAP))
>                         break;
> @@ -2161,13 +2161,13 @@ static const char *check_image_kernel(struct swsusp_info *info)
>  {
>         if (info->version_code != LINUX_VERSION_CODE)
>                 return "kernel version";
> -       if (strcmp(info->uts.sysname,init_utsname()->sysname))
> +       if (strcmp(info->uts.sysname, init_utsname()->sysname))
>                 return "system type";
> -       if (strcmp(info->uts.release,init_utsname()->release))
> +       if (strcmp(info->uts.release, init_utsname()->release))
>                 return "kernel release";
> -       if (strcmp(info->uts.version,init_utsname()->version))
> +       if (strcmp(info->uts.version, init_utsname()->version))
>                 return "version";
> -       if (strcmp(info->uts.machine,init_utsname()->machine))
> +       if (strcmp(info->uts.machine, init_utsname()->machine))
>                 return "machine";
>         return NULL;
>  }
> @@ -2361,7 +2361,7 @@ static int unpack_orig_pfns(unsigned long *buf, struct memory_bitmap *bm,
>                 struct memory_bitmap *zero_bm)
>  {
>         unsigned long decoded_pfn;
> -        bool zero;
> +       bool zero;
>         int j;
>
>         for (j = 0; j < PAGE_SIZE / sizeof(long); j++) {
> --

Applied (with rewritten subject and changelog) as 6.17 material, thanks!