linux-kernel - Re: [PATCH v4 3/5] drm/amd: Avoid evicting resources at S5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_Pn=0nCD-CyoeJxSAn=Gtn=evkaCBUH2pr_O-=7vpw+bw@mail.gmail.com>
Date: Thu, 17 Jul 2025 15:10:47 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Mario Limonciello <superm1@...nel.org>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Alex Deucher <alexander.deucher@....com>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, 
	"open list:RADEON and AMDGPU DRM DRIVERS" <amd-gfx@...ts.freedesktop.org>, 
	"open list:HIBERNATION (aka Software Suspend, aka swsusp)" <linux-pm@...r.kernel.org>, 
	"open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Danilo Krummrich <dakr@...nel.org>, 
	"James E . J . Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K . Petersen" <martin.petersen@...cle.com>, 
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>, 
	"open list:SCSI SUBSYSTEM" <linux-scsi@...r.kernel.org>, 
	"open list:USB SUBSYSTEM" <linux-usb@...r.kernel.org>, Mario Limonciello <mario.limonciello@....com>, 
	AceLan Kao <acelan.kao@...onical.com>, Kai-Heng Feng <kaihengf@...dia.com>, 
	Mark Pearson <mpearson-lenovo@...ebb.ca>, Denis Benato <benato.denis96@...il.com>, 
	Merthan Karakaş <m3rthn.k@...il.com>
Subject: Re: [PATCH v4 3/5] drm/amd: Avoid evicting resources at S5

On Mon, Jun 16, 2025 at 1:50 PM Mario Limonciello <superm1@...nel.org> wrote:
>
> From: Mario Limonciello <mario.limonciello@....com>
>
> Normally resources are evicted on dGPUs at suspend or hibernate and
> on APUs at hibernate.  These steps are unnecessary when using the S4
> callbacks to put the system into S5.
>
> Cc: AceLan Kao <acelan.kao@...onical.com>
> Cc: Kai-Heng Feng <kaihengf@...dia.com>
> Cc: Mark Pearson <mpearson-lenovo@...ebb.ca>
> Cc: Denis Benato <benato.denis96@...il.com>
> Cc: Merthan Karakaş <m3rthn.k@...il.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Acked-by: Alex Deucher <alexander.deucher@....com>

> ---
> v3: https://lore.kernel.org/linux-pm/20250609024619.407257-1-superm1@kernel.org/T/#me6db0fb946e3d604a8f3d455128844ed802c82bb
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 8edd88328749b..c5d8f6d551238 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -4966,6 +4966,10 @@ static int amdgpu_device_evict_resources(struct amdgpu_device *adev)
>         if (!adev->in_s4 && (adev->flags & AMD_IS_APU))
>                 return 0;
>
> +       /* No need to evict when going to S5 through S4 callbacks */
> +       if (system_state == SYSTEM_HALT || system_state == SYSTEM_POWER_OFF)
> +               return 0;
> +
>         ret = amdgpu_ttm_evict_resources(adev, TTM_PL_VRAM);
>         if (ret)
>                 DRM_WARN("evicting device resources failed\n");
> --
> 2.43.0
>