linux-kernel - Re: [PATCH v3] docs: document linked lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87seiua90m.fsf@trenco.lwn.net>
Date: Thu, 17 Jul 2025 13:54:01 -0600
From: Jonathan Corbet <corbet@....net>
To: Nikolay Borisov <nik.borisov@...e.com>, Nicolas Frattaroli
 <nicolas.frattaroli@...labora.com>
Cc: Randy Dunlap <rdunlap@...radead.org>, kernel@...labora.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] docs: document linked lists

Nikolay Borisov <nik.borisov@...e.com> writes:

> Nit: I think it's unnecessary to repeat the initilization in code since 
> you've already explicitly mentioned you continue form State 2 of the 
> previous example, so the only salient information is the additional 
> list_bulk_move_tail call.

[...]

I have a nit of my own: now that the kerneldoc for the hlist functions
is here (it naturally moved with the rest), it would be nice to have
some sort of mention, even if just a paragraph saying why hlists exist
and when one might want to use them.

That said, I have gone ahead and applied this; we've put Nicolas through
enough rounds, and I'd like to get this in for the 6.17 merge window.
The nits can be addressed at leisure with follow-on patches.

Thanks,

jon